FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Integration test for InstanceAdmin::ListInstances. by coryan · Pull Request #371 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

Integration test for InstanceAdmin::ListInstances. - #371

Merged
coryan merged 2 commits into
googleapis:masterfrom
coryan:instance-admin-integration
Mar 25, 2018
ConversationCommits (2)ChecksFiles changed
Merged

Integration test for InstanceAdmin::ListInstances.#371
coryan merged 2 commits into
googleapis:masterfrom
coryan:instance-admin-integration

Conversation

coryan commented Mar 24, 2018

Copy link
Copy Markdown
Contributor

This fixes #343.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2018
mbrukman approved these changes Mar 24, 2018
View reviewed changes

mbrukman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Minor changes suggested below.

Comment thread bigtable/tests/instance_admin_integration_test.cc Outdated
if (argc != 2) {
std::string const cmd = argv[0];
auto last_slash = std::string(cmd).find_last_of('/');
// Show Usage if invalid no of arguments

mbrukman Mar 24, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

s/no/number/

coryan Mar 25, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

Comment thread bigtable/tests/instance_admin_integration_test.cc Outdated

class InstanceAdminIntegrationTest : public testing::Test {
protected:
std::unique_ptr<bigtable::InstanceAdmin> instance_admin_;

mbrukman Mar 24, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Put member variables last, after methods?

coryan Mar 25, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

Comment thread bigtable/tests/instance_admin_integration_test.cc Outdated

std::string InstanceTestEnvironment::project_id_;

class InstanceAdminIntegrationTest : public testing::Test {

mbrukman Mar 24, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

s/testing::Test/::testing::Test/ ?

Above, ::testing::Environment uses absolute namespace reference.

coryan Mar 25, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

coryan merged commit 27da1c1 into googleapis:master Mar 25, 2018
coryan deleted the instance-admin-integration branch March 25, 2018 01:38
roopak-qlogic pushed a commit to roopak-qlogic/google-cloud-cpp that referenced this pull request Apr 1, 2018
Integration test for InstanceAdmin::ListInstances. (googleapis#371)
78b1c5b 
This fixes googleapis#343.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sduskis Awaiting requested review from sduskis
deepankarsharma Awaiting requested review from deepankarsharma
richjames0 Awaiting requested review from richjames0
hemant-qlogic Awaiting requested review from hemant-qlogic
manish-qlogic Awaiting requested review from manish-qlogic
ghaisa Awaiting requested review from ghaisa
1 more reviewer
mbrukman mbrukman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create integration test for InstanceAdmin::ListInstances

3 participants

Back | FazBrowse Home | New Git URL