Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @devbww, @mr-salty, and @scotthart)

CHANGELOG.md, line 13 at r1 (raw file):

### Storage

**BREAKING CHANGES**

nit: blank line after the **BREAKING CHANGES**?

CHANGELOG.md, line 14 at r1 (raw file):

**BREAKING CHANGES**
* fix(storage)!: use nlohmann_json library as any other dependency (#4747)

Normally we include a longer description for breaking changes, you could use the original PR/commit description:

* After this change applications using CMake must install the
  [nlohmann_json][nlohmann-json-gh] library. Automatically downloading
  the library (a) creates problems for package maintainers, (b) requires
  brittle code to keep the symbols from leaking, and (c) creates problems
  for users that need newer versions of this library, for example, because
  they are using a compiler that was not supported by the version we pick.
  * Applications using Bazel or CMake super builds should not be impacted.
  * We have updated our instructions to install this library from source on
     multiple Linux distributions.
  * Applications using a package manager will need to update their build
    scripts to add this dependency.
* In addition, this removes a number of symbols in the
  `google_cloud_cpp_internal_nlohmman_json_3_4_0::` namespace.
  Obviously we never intended these symbols for public use, but we
  should have been clearer about it.

[nlohmann-json-gh]: https://github.com/nlohmann/json.git

CHANGELOG.md, line 19 at r1 (raw file):

* doc(storage): fix typo in quickstart/README.md (#4857)
* doc: update quickstart README files (#4980)

The last two could be summarized I think..

CHANGELOG.md, line 27 at r1 (raw file):

* doc(spanner): fix quickstart/README.md (#4855)
* doc: update quickstart README files (#4980)

These two could be summarized I think:

* doc: update quickstart README files (#4980) (#4855)

CHANGELOG.md, line 33 at r1 (raw file):

* feat(common): non-proto values in PaginationRange (#4806)
* feat: a LogWrapper for future<Status> (#4772)

Seems like an internal-only change.

CHANGELOG.md, line 35 at r1 (raw file):

* feat: a LogWrapper for future<Status> (#4772)
* feat: add a `KmsKeyName` class (#4891)
* feat: add the ContainsOnce() matcher to testing_util (#4913)

I would skip test_util changes, they are not interesting for users.

CHANGELOG.md, line 41 at r1 (raw file):

* fix: clang-tidy works on all headers (#4844)
* fix: cmake configs missing find_dependency(abseil) (#4919)
* refactor: use absl::{con,dis}junction instead of our own (#4826)

Probably uninteresting, it is in the internal-namespace only, that is tru for #4972 #4973 and #4806 (above) too.

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @coryan, @devbww, and @mr-salty)

CHANGELOG.md, line 14 at r1 (raw file):

Normally we include a longer description for breaking changes, you could use the original PR/commit description:

* After this change applications using CMake must install the
  [nlohmann_json][nlohmann-json-gh] library. Automatically downloading
  the library (a) creates problems for package maintainers, (b) requires
  brittle code to keep the symbols from leaking, and (c) creates problems
  for users that need newer versions of this library, for example, because
  they are using a compiler that was not supported by the version we pick.
  * Applications using Bazel or CMake super builds should not be impacted.
  * We have updated our instructions to install this library from source on
     multiple Linux distributions.
  * Applications using a package manager will need to update their build
    scripts to add this dependency.
* In addition, this removes a number of symbols in the
  `google_cloud_cpp_internal_nlohmman_json_3_4_0::` namespace.
  Obviously we never intended these symbols for public use, but we
  should have been clearer about it.

[nlohmann-json-gh]: https://github.com/nlohmann/json.git

Done.

CHANGELOG.md, line 19 at r1 (raw file):

The last two could be summarized I think..

Done.

CHANGELOG.md, line 27 at r1 (raw file):

These two could be summarized I think:

* doc: update quickstart README files (#4980) (#4855)

Done.

CHANGELOG.md, line 33 at r1 (raw file):

Seems like an internal-only change.

Done.

CHANGELOG.md, line 35 at r1 (raw file):

I would skip test_util changes, they are not interesting for users.

Done.

CHANGELOG.md, line 41 at r1 (raw file):

Probably uninteresting, it is in the internal-namespace only, that is tru for #4972 #4973 and #4806 (above) too.

Done.

You may want to make sure nothing interesting happened since yesterday, but otherwise this

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @devbww and @mr-salty)