refactor(generator): use common version and inline namespace for generated code - #5174
Conversation
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #5174 +/- ##
==========================================
+ Coverage 95.79% 95.80% +0.01%
==========================================
Files 1006 1012 +6
Lines 91645 91743 +98
==========================================
+ Hits 87792 87897 +105
+ Misses 3853 3846 -7
Continue to review full report at Codecov.
|
Sorry, something went wrong.
| if (nspace == "GOOGLE_CLOUD_CPP_NS") { | ||
| p.Print("inline namespace $namespace$ {\n", "namespace", nspace); | ||
| } else { | ||
| p.Print("namespace $namespace$ {\n", "namespace", nspace); |
There was a problem hiding this comment.
Nit: This is another one of those cases where it is really just the "inline " bit that is conditional. That is, ...
if (nspace == "GOOGLE_CLOUD_CPP_NS") p.Print("inline ");
p.Print("namespace $namespace$ {\n", "namespace", nspace);
Sorry, something went wrong.
coryan
left a comment
There was a problem hiding this comment.
I think this will also fix the MSVC+x86 breakage. Thanks!
Reviewed 35 of 35 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scotthart)
Sorry, something went wrong.
This change is