fix(googleapis): install directories for protos - #5783
Merged
coryan merged 3 commits intoJan 31, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fix the destination directory for `.proto` files. Improve the `clang-tidy` build to better detect such problems in the future.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #5783 +/- ##
==========================================
- Coverage 95.46% 95.45% -0.01%
==========================================
Files 1113 1113
Lines 102360 102360
==========================================
- Hits 97714 97710 -4
- Misses 4646 4650 +4
Continue to review full report at Codecov.
|
Sorry, something went wrong.
coryan
marked this pull request as ready for review
January 30, 2021 21:42
devbww
reviewed
Jan 31, 2021
Comment thread
ci/kokoro/docker/build-in-docker-cmake.sh
Outdated
Comment thread
ci/kokoro/docker/build-in-docker-cmake.sh
Outdated
Comment thread
ci/kokoro/docker/build-in-docker-cmake.sh
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Thanks, PTAL. |
Sorry, something went wrong.
devbww
approved these changes
Jan 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the destination directory for .proto files. Improve the
clang-tidy build to better detect such problems in the future.
Fixes #5781
This change is