ci(gcb): add --docker flag - #6122
Merged
devjgm merged 4 commits intoMar 26, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This PR adds the `-d | --docker` flags to run the specified build using the local docker. This let's users run our GCB builds locally in an environment that's very similar (exact? pretty close) to the GCB environment. This also makes debugging easier. Users can start a bash shell in the specified docker container by passing the `-s | --docker_shell` flag. Examples: ``` build.sh cmake-install # Runs build on GCB build.sh cmake-install --local # Runs build on your local machine build.sh cmake-install --docker # Runs build in docker build.sh cmake-install --docker-shell # Starts shell in docker ``` These docker builds create a "build-out" directory on the host system to store all their output (similar to our current "cmake-out" directory, but not cmake-specific). All their build output is stored in a build-specific dir w/in build-out/.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #6122 +/- ##
=======================================
Coverage 95.66% 95.67%
=======================================
Files 1173 1173
Lines 104842 104827 -15
=======================================
- Hits 100301 100296 -5
+ Misses 4541 4531 -10
Continue to review full report at Codecov.
|
Sorry, something went wrong.
devjgm
marked this pull request as ready for review
March 26, 2021 19:25
devbww
approved these changes
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the -d | --docker flags to run the specified build using
the local docker. This let's users run our GCB builds locally in an
environment that's very similar (exact? pretty close) to the GCB
environment. This also makes debugging easier. Users can start a bash
shell in the specified docker container by passing the -s | --docker_shell
flag.
Examples:
These docker builds create a "build-out" directory on the host system to
store all their output (similar to our current "cmake-out" directory,
but not cmake-specific). All their build output is stored in a
build-specific dir w/in build-out/.
Coming soon... gcloud ADC credentials will be available in the container so that integration tests work.
This change is