ci(gcb): set TZ=:UTC; log google_time - #6124
Conversation
Sorry, something went wrong.
Per @devbww's comments on googleapis#6123, we set `TZ=:UTC` for docker and GCB builds so our logs -- and others' logs -- show up in UTC to make them easily comparable. This PR also logs the time that google.com thinks it is, which would help us diagnose issues caused by time synchronization issues (which we've seen on Kokoro).
|
Example output: ====================
| Machine Info |
====================
utc: 2021-03-28 14:10:52+00:00
google: 2021-03-28 14:10:52+00:00
kernel: #41~18.04.1-Ubuntu SMP Fri Feb 26 22:23:13 UTC 2021
os: PRETTY_NAME="Fedora 33 (Container Image)"
nproc: 32
mem: 28.21 GiB
gcc: gcc (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9)
clang: clang version 11.0.0 (Fedora 11.0.0-2.fc33)
cc: cc (GCC) 10.2.1 20201125 (Red Hat 10.2.1-9)
cmake: cmake version 3.19.7
bazel: bazel 3.5.0
|
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #6124 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 1173 1173
Lines 104827 104827
=======================================
Hits 100296 100296
Misses 4531 4531 Continue to review full report at Codecov.
|
Sorry, something went wrong.
| io::log_h1 "Machine Info" | ||
| TZ=/etc/localtime printf "%10s %s (%s)\n" "local:" "$(date)" "$(date +%z)" | ||
| printf "%10s %s\n" "utc:" "$(date -u)" | ||
| printf "%10s %s\n" "utc:" "$(date -u --rfc-3339=seconds)" |
There was a problem hiding this comment.
I wonder about the "utc" label. The time is self identifying ... it doesn't really need/want a time-zone label.
Perhaps the difference between "utc" and "google" is more the difference between "host time" and "network time"?
Sorry, something went wrong.
There was a problem hiding this comment.
Done. Though named just "host" and "google" to keep alignment nice.
Sorry, something went wrong.
| "--rm" | ||
| "--user=$(id -u):$(id -g)" | ||
| "--env=USER=$(id -un)" | ||
| "--env=TZ=:UTC" |
There was a problem hiding this comment.
I'm having second thoughts about the precise incantation. TZ=:UTC will probably only work on tzdb-based implementations that compile the "backward" rules, and I'm not sure who does that.
We're probably better off with TZ=UTC0, which will work on any system that supports the POSIX TZ spec, and that includes any Unix-like libc, plus Windows I believe. Abseil/CCTZ will actually fail to load "UTC0" (unlike bare "UTC", which we special case), but it will then fall back to UTC, so that's OK. [But I think I'll tweak CCTZ so that loading "UTC0" returns success too.]
Sorry, something went wrong.
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
Per @devbww's comments on
#6123, we set
TZ=:UTC for docker and GCB builds so our logs -- and others' logs --
show up in UTC to make them easily comparable. This PR also logs the
time that google.com thinks it is, which would help us diagnose issues
caused by time synchronization issues (which we've seen on Kokoro).
This change is