ci(gcb): adds flags to generate yaml triggers - #6125
Merged
devjgm merged 1 commit intoMar 28, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Adds flags to output the YAML configs for a named build. The generated YAML config can then be manually tweaked (if needed), and checked in. Generating the config doesn't actually submit the file to GCB. To do that, you must then use `trigger.sh --import <new-yaml-file>`. I also used these flags to generate configs for a few builds that were missing triggers and therefore weren't running (like integration and xsan). I also simplified the yaml configs: - I removed the created time and trigger IDs, which are output-only fields - I removed the trigger tags, which don't really do anything useful, and are difficult to generate automatically
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #6125 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 1173 1173
Lines 104827 104827
=======================================
Hits 100296 100296
Misses 4531 4531 Continue to review full report at Codecov.
|
Sorry, something went wrong.
devbww
approved these changes
Mar 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds flags to output the YAML configs for a named build. The generated
YAML config can then be manually tweaked (if needed), and checked in.
Generating the config doesn't actually submit the file to GCB. To do
that, you must then use trigger.sh --import <new-yaml-file>.
I also used these flags to generate configs for a few builds that were
missing triggers and therefore weren't running (like integration and
xsan).
I also simplified the yaml configs:
fields
are difficult to generate automatically
This change is