FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: April 2021 release notes and ABI update by devjgm · Pull Request #6172 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

chore: April 2021 release notes and ABI update - #6172

Merged
devjgm merged 2 commits into
googleapis:masterfrom
devjgm:april-release
Apr 1, 2021
ConversationCommits (2)ChecksFiles changed
Merged

chore: April 2021 release notes and ABI update#6172
devjgm merged 2 commits into
googleapis:masterfrom
devjgm:april-release

Conversation

devjgm commented Apr 1, 2021 •
edited by coryan
Loading

Copy link
Copy Markdown
Contributor

This change is 

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2021
coryan reviewed Apr 1, 2021
View reviewed changes

coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we should separate the breaking and non-breaking changes for bigtable?

Comment thread CHANGELOG.md Outdated
`BackgroundThreadsFactory()` member function, requiring anyone who derives
from those classes to implement that function. This would typically only
affect users who create mock clients for testing purposes.
* fix(bigtable): multiple region tags on same line (#6051)

coryan Apr 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These changes are not breaking, right? So we can split them with a **OTHER CHANGES**: header (or whatever we have used in the past)?

Also, #6051 was probably mislabeled, it is a cleanup and uninteresting to customers.

codecov Bot commented Apr 1, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6172 (7fdced7) into master (c893624) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6172   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files        1173     1173           
  Lines      104899   104899           
=======================================
  Hits       100361   100361           
  Misses       4538     4538

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c893624...7fdced7. Read the comment docs.

devjgm marked this pull request as ready for review April 1, 2021 16:48
devjgm requested a review from a team April 1, 2021 16:48
devjgm merged commit 6bc6b50 into googleapis:master Apr 1, 2021
devjgm deleted the april-release branch April 1, 2021 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coryan coryan approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL