FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(deps): upgrade pkg-config on CentOS-7 to avoid bug by devjgm · Pull Request #6846 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

chore(deps): upgrade pkg-config on CentOS-7 to avoid bug - #6846

Merged
devjgm merged 1 commit into
googleapis:mainfrom
devjgm:centos7-pkg-config
Jun 23, 2021
ConversationCommits (1)ChecksFiles changed
Merged

chore(deps): upgrade pkg-config on CentOS-7 to avoid bug#6846
devjgm merged 1 commit into
googleapis:mainfrom
devjgm:centos7-pkg-config

Conversation

devjgm commented Jun 22, 2021 •
edited by coryan
Loading

Copy link
Copy Markdown
Contributor

There's a bug w/ CentOS-7's version of pkg-config that can cause
invocations to take a reeeeeaaaaly long time to complete. We discovered
this when upgrading to grpc-1.38.1 and had to rollback the upgrade.

The fix to pkg-config was rolled out about 8 years ago in pkg-config
0.28. This PR upgrades the pkg-config we use on CentOS-7 to the latest
as of this writing. After this, I think we should be able to upgrade
grpc again.

This change is 

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021

google-cloud-cpp-bot commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 2ebf36ac252c925cae96277619d7710274740500

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devjgm force-pushed the centos7-pkg-config branch from 2ebf36a to 2a3314e Compare June 22, 2021 22:22

google-cloud-cpp-bot commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 2a3314ee43e16f2e2abfb6fbfca636776f993502

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devjgm marked this pull request as ready for review June 22, 2021 22:24
devjgm requested a review from a team June 22, 2021 22:24

codecov Bot commented Jun 22, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6846 (a249c26) into main (f6e4b11) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6846   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files        1264     1264           
  Lines      113324   113324           
=======================================
+ Hits       107682   107686    +4     
+ Misses       5642     5638    -4
Impacted Files Coverage Δ
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.76% <0.00%> (-0.47%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.75% <0.00%> (+0.07%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.02% <0.00%> (+0.24%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 81.41% <0.00%> (+0.44%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 97.90% <0.00%> (+0.69%) ⬆️
google/cloud/bigtable/internal/common_client.cc 97.14% <0.00%> (+1.42%) ⬆️
google/cloud/internal/async_rpc_details.h 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e4b11...a249c26. Read the comment docs.

chore(deps): upgrade pkg-config on CentOS-7 to avoid bug
a249c26 
There's a [bug] w/ CentOS-7's version of `pkg-config` that can cause
invocations to take a reeeeeaaaaly long time to complete. We discovered
this when upgrading to grpc-1.38.1 and had to [rollback] the upgrade.

The fix to `pkg-config` was rolled out about 8 years ago in `pkg-config`
0.28. This PR upgrades the pkg-config we use on CentOS-7 to the latest
as of this writing. After this, I think we should be able to upgrade
grpc again.

[bug]: https://bugs.freedesktop.org/show_bug.cgi?id=54716
[rollback]: googleapis#6840
devjgm force-pushed the centos7-pkg-config branch from 2a3314e to a249c26 Compare June 23, 2021 13:50

google-cloud-cpp-bot commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: a249c26a9cb7aebb7e472e5f931aeab095fc34fa

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devjgm merged commit 82c72de into googleapis:main Jun 23, 2021
devjgm deleted the centos7-pkg-config branch June 23, 2021 14:36
devjgm mentioned this pull request Jun 23, 2021
Merged
veblush mentioned this pull request Jun 24, 2021
Merged
devjgm mentioned this pull request Jul 23, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coryan coryan approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL