FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: update CHANGELOG and set version for v1.30.1 release by scotthart · Pull Request #7152 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

chore: update CHANGELOG and set version for v1.30.1 release - #7152

Merged
scotthart merged 3 commits into
googleapis:v1.30.xfrom
scotthart:v1_30_1_release
Aug 10, 2021
ConversationCommits (3)ChecksFiles changed
Merged

chore: update CHANGELOG and set version for v1.30.1 release#7152
scotthart merged 3 commits into
googleapis:v1.30.xfrom
scotthart:v1_30_1_release

Conversation

scotthart commented Aug 10, 2021 •
edited by coryan
Loading

Copy link
Copy Markdown
Member

This change is 

scotthart requested a review from a team August 10, 2021 20:34
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2021

google-cloud-cpp-bot commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 068dab64d8fd6e0561e94b43e2a30af6b79896cc

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devjgm reviewed Aug 10, 2021
View reviewed changes

devjgm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I assume you'll need to this branch back into main after the release? Or just cherry pick a few commits to main? I'm not sure.

Comment thread CHANGELOG.md Outdated

## v1.31.0 - TBD

## v1.31.1 - 2021-08-10

devjgm Aug 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this version should be 1.30.1.

google-cloud-cpp-bot commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 0bbfd19756b82aae794e1c2153b295cc5ea74814

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

scotthart commented Aug 10, 2021
View reviewed changes

scotthart left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'll cherry pick the cmake change commit and the changelog + version commit.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @devjgm)

CHANGELOG.md, line 57 at r1 (raw file):

Previously, devjgm (Greg Miller) wrote…

I think this version should be 1.30.1.

Fixed

devbww reviewed Aug 10, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated

## v1.31.0 - TBD

## v1.30.1 - 2021-08-10

devbww Aug 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For what it's worth, it doesn't look like we've ever added a "-DD" before.

codecov Bot commented Aug 10, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7152 (727b2cd) into v1.30.x (ae48ad8) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           v1.30.x    #7152      +/-   ##
===========================================
- Coverage    94.49%   94.49%   -0.01%     
===========================================
  Files         1308     1308              
  Lines       112978   112978              
===========================================
- Hits        106759   106753       -6     
- Misses        6219     6225       +6
Impacted Files Coverage Δ
...le/cloud/storage/internal/curl_download_request.cc 87.95% <0.00%> (-0.81%) ⬇️
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.78% <0.00%> (-0.25%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.75% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae48ad8...727b2cd. Read the comment docs.

scotthart commented Aug 10, 2021
View reviewed changes

scotthart left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @devbww and @devjgm)

CHANGELOG.md, line 57 at r2 (raw file):

Previously, devbww (Bradley White) wrote…

For what it's worth, it doesn't look like we've ever added a "-DD" before.

I think the extra information could be useful to some users.

scotthart requested review from devbww and devjgm August 10, 2021 22:11

google-cloud-cpp-bot commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 727b2cdb92db42b6dd3d0b7a209c2e12e565e778

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

scotthart merged commit 00c2dec into googleapis:v1.30.x Aug 10, 2021
scotthart added a commit to scotthart/google-cloud-cpp that referenced this pull request Aug 10, 2021
chore: update CHANGELOG and set version for v1.30.1 release (googleap…
7959d2f 
…is#7152)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dbolduc dbolduc approved these changes
devjgm Awaiting requested review from devjgm
devbww Awaiting requested review from devbww

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL