FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(release): update changelog for 2021-09 release by dbolduc · Pull Request #7245 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

chore(release): update changelog for 2021-09 release - #7245

Merged
dbolduc merged 2 commits into
googleapis:mainfrom
dbolduc:update-changelog
Sep 1, 2021
ConversationCommits (2)ChecksFiles changed
Merged

chore(release): update changelog for 2021-09 release#7245
dbolduc merged 2 commits into
googleapis:mainfrom
dbolduc:update-changelog

Conversation

dbolduc commented Sep 1, 2021 •
edited by coryan
Loading

Copy link
Copy Markdown
Member

This change is 

dbolduc requested a review from a team September 1, 2021 15:40
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2021

google-cloud-cpp-bot commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: e243cd74362b9d77e3d64d09a6019f5fda56b4f5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devbww reviewed Sep 1, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
* feat(common): add GrpcChannelArgumentsNativeOption ([#7194](https://github.com/googleapis/google-cloud-cpp/pull/7194))
* feat(common): capture thread that creates log record ([#7119](https://github.com/googleapis/google-cloud-cpp/pull/7119))


devbww Sep 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nitty nit: Delete extra blank line.

dbolduc Sep 1, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed

codecov Bot commented Sep 1, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7245 (ee7291b) into main (be1513b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7245      +/-   ##
==========================================
- Coverage   94.35%   94.35%   -0.01%     
==========================================
  Files        1317     1317              
  Lines      114503   114503              
==========================================
- Hits       108040   108037       -3     
- Misses       6463     6466       +3
Impacted Files Coverage Δ
...le/cloud/storage/internal/curl_download_request.cc 88.10% <0.00%> (-1.12%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.75% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be1513b...ee7291b. Read the comment docs.

coryan approved these changes Sep 1, 2021
View reviewed changes

coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One minor nit.

Comment thread CHANGELOG.md Outdated
* feat(storage): add additional examples ([#7224](https://github.com/googleapis/google-cloud-cpp/pull/7224))
* feat(storage): aggregate upload benchmark ([#7190](https://github.com/googleapis/google-cloud-cpp/pull/7190))
* fix(GCS+gRPC): quickstart build with Bazel+Windows ([#7147](https://github.com/googleapis/google-cloud-cpp/pull/7147))
* refactor(storage): isolate header parsing to REST ([#7137](https://github.com/googleapis/google-cloud-cpp/pull/7137))

coryan Sep 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Typically we do not include refactor information in the CHANGELOG.

devjgm Sep 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We could update

google-cloud-cpp/release/changes.sh

Line 51 in be1513b

if grep -qP "^(ci|chore|test|testing|cleanup)\b" <<<"${message}"; then
to exclude refactor by default.

dbolduc Sep 1, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I removed others, but wasn't sure about this one. I will remove it.

google-cloud-cpp-bot commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: ee7291b2b2cc201fa725b9ffb2a37609ab3e88c4

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

dbolduc merged commit 890a3ef into googleapis:main Sep 1, 2021
dbolduc deleted the update-changelog branch September 1, 2021 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coryan coryan approved these changes
+2 more reviewers
devbww devbww left review comments
devjgm devjgm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL