FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(release): update changelog for 2021-10 release by devbww · Pull Request #7386 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

chore(release): update changelog for 2021-10 release - #7386

Merged
devbww merged 3 commits into
googleapis:mainfrom
devbww:release
Oct 1, 2021
ConversationCommits (3)ChecksFiles changed
Merged

chore(release): update changelog for 2021-10 release#7386
devbww merged 3 commits into
googleapis:mainfrom
devbww:release

Conversation

devbww commented Oct 1, 2021 •
edited by coryan
Loading

Copy link
Copy Markdown
Contributor

This change is 

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2021

google-cloud-cpp-bot commented Oct 1, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 77c23825dde50c8e560b44b8ae309ad805872d67

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

codecov Bot commented Oct 1, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7386 (d7af422) into main (39d87d4) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7386      +/-   ##
==========================================
- Coverage   93.65%   93.64%   -0.01%     
==========================================
  Files        1351     1351              
  Lines      117334   117334              
==========================================
- Hits       109886   109883       -3     
- Misses       7448     7451       +3
Impacted Files Coverage Δ
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.02% <0.00%> (-0.08%) ⬇️
google/cloud/grpc_error_delegate.cc 100.00% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d87d4...d7af422. Read the comment docs.

devbww marked this pull request as ready for review October 1, 2021 07:57
devbww requested a review from a team October 1, 2021 07:57
coryan requested changes Oct 1, 2021
View reviewed changes

coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we should summarize the Pub/Sub changes. My other comments are nits and optional.

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated

google-cloud-cpp-bot commented Oct 1, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 574e66c759b33e1054125ad19f2d9fecb7575889

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

coryan approved these changes Oct 1, 2021
View reviewed changes

coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A couple more nits, address them and we are good to go.

Comment thread CHANGELOG.md Outdated

### [BigQuery](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/bigquery/README.md)

* feat(generator): generate a SetIamPolicy() overload with an OCC loop ([#7276](https://github.com/googleapis/google-cloud-cpp/pull/7276))

coryan Oct 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I do not think this change affected BigQuery?

devbww Oct 1, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops. Removed. Thanks.

Comment thread CHANGELOG.md Outdated

* feat(pubsub): use `google::cloud::Options` to configure the library.
`pubsub::PublisherOptions`, `pubsub::SubscriberOptions`, and related
functions are deprecated. We have not set a date to remove them.

coryan Oct 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

s/remove them./remove them, if we ever do, we plan to give you a year notice./

Or a better way to say that if/when we set a date, it will be at least a year after we make the decision to remove them.

devbww Oct 1, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

google-cloud-cpp-bot commented Oct 1, 2021

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: d7af4227f23171f3bbf813404bfa105440fc7881

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devbww merged commit 58ea920 into googleapis:main Oct 1, 2021
devbww deleted the release branch October 1, 2021 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dbolduc dbolduc left review comments
coryan coryan approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL