FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update CHANGELOG for v1.37.0 release by devbww · Pull Request #8474 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

doc: update CHANGELOG for v1.37.0 release - #8474

Merged
devbww merged 4 commits into
googleapis:mainfrom
devbww:release
Mar 1, 2022
ConversationCommits (4)ChecksFiles changed
Merged

doc: update CHANGELOG for v1.37.0 release#8474
devbww merged 4 commits into
googleapis:mainfrom
devbww:release

Conversation

devbww commented Mar 1, 2022 •
edited by coryan
Loading

Copy link
Copy Markdown
Contributor

This change is 

devbww requested a review from a team March 1, 2022 07:46

google-cloud-cpp-bot commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 23a88e1a4312ae89ad891dedb6a620715bf87aa0

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

codecov Bot commented Mar 1, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8474 (a48899b) into main (2c6dd06) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8474   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files        1451     1451           
  Lines      125777   125777           
=======================================
+ Hits       118125   118128    +3     
+ Misses       7652     7649    -3
Impacted Files Coverage Δ
google/cloud/pubsub/subscriber_connection_test.cc 97.22% <0.00%> (-0.70%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (-0.50%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.02% <0.00%> (-0.08%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.25% <0.00%> (+0.49%) ⬆️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6dd06...a48899b. Read the comment docs.

google-cloud-cpp-bot commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: fd84b47c4ae9514496b6655f2835dfc770543c88

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

dbolduc requested changes Mar 1, 2022
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
coryan reviewed Mar 1, 2022
View reviewed changes

coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Most what dbolduc@ said.

Comment thread CHANGELOG.md Outdated
* fix: wait until AutomaticallyCreatedBackgroundThreads start ([#8452](https://github.com/googleapis/google-cloud-cpp/pull/8452))
* fix(oauth2): compute engine credential query ([#8421](https://github.com/googleapis/google-cloud-cpp/pull/8421))
* fix: restore Options over deletion of StreamRange<T>::reader_ ([#8403](https://github.com/googleapis/google-cloud-cpp/pull/8403))
* feat(common): ddd converting constructors for future ([#8329](https://github.com/googleapis/google-cloud-cpp/pull/8329))

coryan Mar 1, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think ddd is a typo, just remove please.

devbww Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

devbww commented Mar 1, 2022
View reviewed changes

devbww left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks.

google-cloud-cpp-bot commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: fdd80462f5465ec339db5e59c165a958083014f6

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

dbolduc reviewed Mar 1, 2022
View reviewed changes
Comment thread CHANGELOG.md Outdated
* fix: wait until AutomaticallyCreatedBackgroundThreads start ([#8452](https://github.com/googleapis/google-cloud-cpp/pull/8452))
* fix(oauth2): compute engine credential query ([#8421](https://github.com/googleapis/google-cloud-cpp/pull/8421))
* fix: restore Options over deletion of StreamRange<T>::reader_ ([#8403](https://github.com/googleapis/google-cloud-cpp/pull/8403))
* feat(common): ddd converting constructors for future ([#8329](https://github.com/googleapis/google-cloud-cpp/pull/8329))

dbolduc Mar 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think coryan meant s/ddd //. Not to delete the whole entry.

devbww Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And so restored (although editing commit messages at this stage seems more confusing to me).

Comment thread CHANGELOG.md

google-cloud-cpp-bot commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: e35d613f74aa5dae865d4412395c9bfec236627e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google-cloud-cpp-bot commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: a48899b42a808cfb4631902e8ceabd450a1e7d5e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devbww merged commit 334e481 into googleapis:main Mar 1, 2022
devbww deleted the release branch March 1, 2022 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coryan coryan approved these changes
dbolduc dbolduc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL