fix: correct check for storage vs. rest enabled - #8855
Merged
coryan merged 1 commit intoMay 2, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
We cannot enable the storage library and disable the `rest-internal` library, unfortunately the check was based on the wrong variables.
devbww
approved these changes
May 2, 2022
coryan
enabled auto-merge (squash)
May 2, 2022 20:54
Copy link
Copy Markdown
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## v1.40.x #8855 +/- ##
========================================
Coverage 93.22% 93.22%
========================================
Files 1463 1463
Lines 124183 124183
========================================
+ Hits 115771 115772 +1
+ Misses 8412 8411 -1
Continue to review full report at Codecov.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot enable the storage library and disable the rest-internal
library, unfortunately the check was based on the wrong variables.
This change is