File system close declares it throws IOException - #1060
Merged
mziccard merged 1 commit intoJun 20, 2016
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This is in case we decide to implement "close all owned channels"
Comment thread
...loud-java-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystem.java
| */ | ||
| @Override | ||
| public void close() {} | ||
| public void close() throws IOException { |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
See my comment on implementing the method rather than putting a TODO. Otherwise LGTM. |
Sorry, something went wrong.
mziccard
pushed a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 29, 2016
mziccard
pushed a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 30, 2016
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.4](googleapis/java-translate@v2.3.3...v2.3.4) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.10 ([#1069](googleapis/java-translate#1069)) ([2bee3ba](googleapis/java-translate@2bee3ba)) * Update dependency com.google.cloud:google-cloud-core to v2.8.11 ([#1073](googleapis/java-translate#1073)) ([8a869f6](googleapis/java-translate@8a869f6)) * Update dependency com.google.cloud:google-cloud-core to v2.8.9 ([#1066](googleapis/java-translate#1066)) ([69d391c](googleapis/java-translate@69d391c)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1074](googleapis/java-translate#1074)) ([c8bfd65](googleapis/java-translate@c8bfd65)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1077](googleapis/java-translate#1077)) ([aa9ef02](googleapis/java-translate@aa9ef02)) * Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1060](googleapis/java-translate#1060)) ([4d9a7ad](googleapis/java-translate@4d9a7ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
….6.23 (#1060) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.22` -> `1.6.23` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-iam</summary> ### [`v1.6.23`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​1623-httpsgithubcomgoogleapisjava-iamcomparev1622v1623-2022-12-20) [Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.22...v1.6.23) ##### Dependencies - Update dependency com.google.api:api-common to v2.3.1 ([#​567](https://togithub.com/googleapis/java-iam/issues/567)) ([17e62e8](https://togithub.com/googleapis/java-iam/commit/17e62e80f0ea8c2d4edfe6bb16ef5ee7acbc22f3)) - Update dependency com.google.auth:google-auth-library-oauth2-http to v1.14.0 ([#​571](https://togithub.com/googleapis/java-iam/issues/571)) ([9c48311](https://togithub.com/googleapis/java-iam/commit/9c48311fbac25f9c9545f3404a42cdadf8ebb243)) - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#​565](https://togithub.com/googleapis/java-iam/issues/565)) ([32be2fb](https://togithub.com/googleapis/java-iam/commit/32be2fb0cfafa3681489c18e367cf12f22c567d3)) - Update dependency com.google.cloud:google-iam-policy to v1.6.22 ([#​560](https://togithub.com/googleapis/java-iam/issues/560)) ([de39d89](https://togithub.com/googleapis/java-iam/commit/de39d89c08c9e45bc977ea393570a8d01cf48af2)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.12 ([#​563](https://togithub.com/googleapis/java-iam/issues/563)) ([607e260](https://togithub.com/googleapis/java-iam/commit/607e2601b71ff1fb51406e6c97dd79208296f404)) - Update dependency com.google.protobuf:protobuf-java to v3.21.12 ([#​564](https://togithub.com/googleapis/java-iam/issues/564)) ([4b2b26b](https://togithub.com/googleapis/java-iam/commit/4b2b26bd29d88ccb602a71225d6e2decb49b9649)) - Update dependency io.grpc:grpc-protobuf to v1.51.1 ([#​573](https://togithub.com/googleapis/java-iam/issues/573)) ([2143ec8](https://togithub.com/googleapis/java-iam/commit/2143ec8a90dbcdb128dffea9777fa9d183c3068e)) - Update dependency io.grpc:grpc-stub to v1.51.1 ([#​574](https://togithub.com/googleapis/java-iam/issues/574)) ([488496a](https://togithub.com/googleapis/java-iam/commit/488496aa09c9d976bf0c450fb8584f07e7c74c03)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
…cies to v3.0.2 (#1060) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `3.0.1` -> `3.0.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v3.0.2`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#​302-httpsgithubcomgoogleapisjava-shared-dependenciescomparev301v302-2022-09-08) [Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v3.0.1...v3.0.2) ##### Dependencies - Update dependency com.fasterxml.jackson:jackson-bom to v2.13.4 ([#​789](https://togithub.com/googleapis/java-shared-dependencies/issues/789)) ([6cf91a9](https://togithub.com/googleapis/java-shared-dependencies/commit/6cf91a96b9ea6af0fb845b50582dac7aa2892cab)) - Update dependency com.google.auth:google-auth-library-bom to v1.10.0 ([#​781](https://togithub.com/googleapis/java-shared-dependencies/issues/781)) ([8859e61](https://togithub.com/googleapis/java-shared-dependencies/commit/8859e61808bfc5cd9546e27e945fc855b36d2554)) - Update dependency com.google.auth:google-auth-library-bom to v1.11.0 ([#​790](https://togithub.com/googleapis/java-shared-dependencies/issues/790)) ([3431a47](https://togithub.com/googleapis/java-shared-dependencies/commit/3431a471cbf874a67a4f1a42e31f0ed891dedc92)) - Update dependency com.google.auth:google-auth-library-bom to v1.9.0 ([#​773](https://togithub.com/googleapis/java-shared-dependencies/issues/773)) ([27fc79f](https://togithub.com/googleapis/java-shared-dependencies/commit/27fc79f00ee70011df6a368bb8fcfad7f0ce41f0)) - Update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#​776](https://togithub.com/googleapis/java-shared-dependencies/issues/776)) ([bf333b8](https://togithub.com/googleapis/java-shared-dependencies/commit/bf333b8c88072d21cb959db4d3328bbb55d9ef5c)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.5 ([#​780](https://togithub.com/googleapis/java-shared-dependencies/issues/780)) ([da7f44d](https://togithub.com/googleapis/java-shared-dependencies/commit/da7f44d71d6d7f372b5313dab68ce220308614d4)) - Update dependency io.grpc:grpc-bom to v1.48.1 ([#​768](https://togithub.com/googleapis/java-shared-dependencies/issues/768)) ([5c7768d](https://togithub.com/googleapis/java-shared-dependencies/commit/5c7768d3c9665dd356de6c39c0a6a5fa6e992f2e)) - Update dependency io.grpc:grpc-bom to v1.49.0 ([#​786](https://togithub.com/googleapis/java-shared-dependencies/issues/786)) ([8734812](https://togithub.com/googleapis/java-shared-dependencies/commit/8734812f1b4e2faaa48caf41eff59a85892ae344)) - Update dependency org.checkerframework:checker-qual to v3.24.0 ([#​775](https://togithub.com/googleapis/java-shared-dependencies/issues/775)) ([df74b7b](https://togithub.com/googleapis/java-shared-dependencies/commit/df74b7b0dd5dd592523f302d9fb36adb5991cb0b)) - Update dependency org.checkerframework:checker-qual to v3.25.0 ([#​788](https://togithub.com/googleapis/java-shared-dependencies/issues/788)) ([207035b](https://togithub.com/googleapis/java-shared-dependencies/commit/207035bd04c9305899eea540acbefaf06a7b1ec9)) - Update dependency org.threeten:threetenbp to v1.6.1 ([#​782](https://togithub.com/googleapis/java-shared-dependencies/issues/782)) ([0f218ae](https://togithub.com/googleapis/java-shared-dependencies/commit/0f218aeb6aa33cf1da4a8b1d6c82bbf87946dab9)) - Update gax.version to v2.19.0 ([#​785](https://togithub.com/googleapis/java-shared-dependencies/issues/785)) ([4448331](https://togithub.com/googleapis/java-shared-dependencies/commit/4448331c4c6d88ea8076260776d1d47d24aa19fa)) - Update google.core.version to v2.8.10 ([#​787](https://togithub.com/googleapis/java-shared-dependencies/issues/787)) ([3c344d5](https://togithub.com/googleapis/java-shared-dependencies/commit/3c344d515e3b9215db5a1f8ef550d800d974e558)) - Update google.core.version to v2.8.7 ([#​774](https://togithub.com/googleapis/java-shared-dependencies/issues/774)) ([d0cd5e8](https://togithub.com/googleapis/java-shared-dependencies/commit/d0cd5e8f6ca88787fe0dbf7f30c849cb4c4fae5e)) - Update google.core.version to v2.8.8 ([#​777](https://togithub.com/googleapis/java-shared-dependencies/issues/777)) ([f00571c](https://togithub.com/googleapis/java-shared-dependencies/commit/f00571cd1e9f1c4e011fba4a1e1674c1d8d60200)) - Update google.core.version to v2.8.9 ([#​784](https://togithub.com/googleapis/java-shared-dependencies/issues/784)) ([aa8e505](https://togithub.com/googleapis/java-shared-dependencies/commit/aa8e505dbb1214b2239e55d5ac83b00c167d77e4)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC4yIn0=-->
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
🤖 I have created a release *beep* *boop* --- ## [3.10.8](googleapis/java-logging@v3.10.7...v3.10.8) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1060](googleapis/java-logging#1060)) ([b5dea1b](googleapis/java-logging@b5dea1b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Jan 6, 2026
chingor13
pushed a commit
that referenced
this pull request
Jan 6, 2026
🤖 I have created a release *beep* *boop* --- ## [0.129.11](https://togithub.com/googleapis/java-logging-logback/compare/v0.129.10...v0.129.11) (2023-04-27) ### Dependencies * Update dependency com.google.cloud:google-cloud-logging to v3.14.8 ([#1060](https://togithub.com/googleapis/java-logging-logback/issues/1060)) ([f6b9108](https://togithub.com/googleapis/java-logging-logback/commit/f6b9108379961c599d18f12a3e80f12ae2aa1195)) * Update dependency com.google.cloud:google-cloud-logging to v3.14.9 ([#1065](https://togithub.com/googleapis/java-logging-logback/issues/1065)) ([241f6bf](https://togithub.com/googleapis/java-logging-logback/commit/241f6bf6e496a99fd6d66574d8a5b6f7b8bafb7d)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.8.0 ([#1064](https://togithub.com/googleapis/java-logging-logback/issues/1064)) ([dd8888e](https://togithub.com/googleapis/java-logging-logback/commit/dd8888e81dee19e88c1160691701381fbb3765ee)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Feb 24, 2026
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
…cies to v3.0.2 (googleapis#1060) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `3.0.1` -> `3.0.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v3.0.2`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#​302-httpsgithubcomgoogleapisjava-shared-dependenciescomparev301v302-2022-09-08) [Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v3.0.1...v3.0.2) ##### Dependencies - Update dependency com.fasterxml.jackson:jackson-bom to v2.13.4 ([#&googleapis#8203;789](https://togithub.com/googleapis/java-shared-dependencies/issues/789)) ([6cf91a9](https://togithub.com/googleapis/java-shared-dependencies/commit/6cf91a96b9ea6af0fb845b50582dac7aa2892cab)) - Update dependency com.google.auth:google-auth-library-bom to v1.10.0 ([#&googleapis#8203;781](https://togithub.com/googleapis/java-shared-dependencies/issues/781)) ([8859e61](https://togithub.com/googleapis/java-shared-dependencies/commit/8859e61808bfc5cd9546e27e945fc855b36d2554)) - Update dependency com.google.auth:google-auth-library-bom to v1.11.0 ([#&googleapis#8203;790](https://togithub.com/googleapis/java-shared-dependencies/issues/790)) ([3431a47](https://togithub.com/googleapis/java-shared-dependencies/commit/3431a471cbf874a67a4f1a42e31f0ed891dedc92)) - Update dependency com.google.auth:google-auth-library-bom to v1.9.0 ([#&googleapis#8203;773](https://togithub.com/googleapis/java-shared-dependencies/issues/773)) ([27fc79f](https://togithub.com/googleapis/java-shared-dependencies/commit/27fc79f00ee70011df6a368bb8fcfad7f0ce41f0)) - Update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#&googleapis#8203;776](https://togithub.com/googleapis/java-shared-dependencies/issues/776)) ([bf333b8](https://togithub.com/googleapis/java-shared-dependencies/commit/bf333b8c88072d21cb959db4d3328bbb55d9ef5c)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.5 ([#&googleapis#8203;780](https://togithub.com/googleapis/java-shared-dependencies/issues/780)) ([da7f44d](https://togithub.com/googleapis/java-shared-dependencies/commit/da7f44d71d6d7f372b5313dab68ce220308614d4)) - Update dependency io.grpc:grpc-bom to v1.48.1 ([#&googleapis#8203;768](https://togithub.com/googleapis/java-shared-dependencies/issues/768)) ([5c7768d](https://togithub.com/googleapis/java-shared-dependencies/commit/5c7768d3c9665dd356de6c39c0a6a5fa6e992f2e)) - Update dependency io.grpc:grpc-bom to v1.49.0 ([#&googleapis#8203;786](https://togithub.com/googleapis/java-shared-dependencies/issues/786)) ([8734812](https://togithub.com/googleapis/java-shared-dependencies/commit/8734812f1b4e2faaa48caf41eff59a85892ae344)) - Update dependency org.checkerframework:checker-qual to v3.24.0 ([#&googleapis#8203;775](https://togithub.com/googleapis/java-shared-dependencies/issues/775)) ([df74b7b](https://togithub.com/googleapis/java-shared-dependencies/commit/df74b7b0dd5dd592523f302d9fb36adb5991cb0b)) - Update dependency org.checkerframework:checker-qual to v3.25.0 ([#&googleapis#8203;788](https://togithub.com/googleapis/java-shared-dependencies/issues/788)) ([207035b](https://togithub.com/googleapis/java-shared-dependencies/commit/207035bd04c9305899eea540acbefaf06a7b1ec9)) - Update dependency org.threeten:threetenbp to v1.6.1 ([#&googleapis#8203;782](https://togithub.com/googleapis/java-shared-dependencies/issues/782)) ([0f218ae](https://togithub.com/googleapis/java-shared-dependencies/commit/0f218aeb6aa33cf1da4a8b1d6c82bbf87946dab9)) - Update gax.version to v2.19.0 ([#&googleapis#8203;785](https://togithub.com/googleapis/java-shared-dependencies/issues/785)) ([4448331](https://togithub.com/googleapis/java-shared-dependencies/commit/4448331c4c6d88ea8076260776d1d47d24aa19fa)) - Update google.core.version to v2.8.10 ([#&googleapis#8203;787](https://togithub.com/googleapis/java-shared-dependencies/issues/787)) ([3c344d5](https://togithub.com/googleapis/java-shared-dependencies/commit/3c344d515e3b9215db5a1f8ef550d800d974e558)) - Update google.core.version to v2.8.7 ([#&googleapis#8203;774](https://togithub.com/googleapis/java-shared-dependencies/issues/774)) ([d0cd5e8](https://togithub.com/googleapis/java-shared-dependencies/commit/d0cd5e8f6ca88787fe0dbf7f30c849cb4c4fae5e)) - Update google.core.version to v2.8.8 ([#&googleapis#8203;777](https://togithub.com/googleapis/java-shared-dependencies/issues/777)) ([f00571c](https://togithub.com/googleapis/java-shared-dependencies/commit/f00571cd1e9f1c4e011fba4a1e1674c1d8d60200)) - Update google.core.version to v2.8.9 ([#&googleapis#8203;784](https://togithub.com/googleapis/java-shared-dependencies/issues/784)) ([aa8e505](https://togithub.com/googleapis/java-shared-dependencies/commit/aa8e505dbb1214b2239e55d5ac83b00c167d77e4)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC4yIn0=-->
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
🤖 I have created a release *beep* *boop* --- ## [3.10.8](googleapis/java-logging@v3.10.7...v3.10.8) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([googleapis#1060](googleapis/java-logging#1060)) ([3647d3d](googleapis/java-logging@3647d3d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Mar 12, 2026
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 30, 2026
lqiu96
pushed a commit
that referenced
this pull request
Apr 1, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
* chore: cleanup cloud RAD generation Updating cloud rad generation to support [java-shared-config/pull/344](googleapis/java-shared-config#344) updates and removing inclusion of README as we're not currently supporting this feature yet Source-Author: Emily Ball <emilyball@google.com> Source-Date: Mon Nov 8 13:23:34 2021 -0800 Source-Repo: googleapis/synthtool Source-Sha: 99ea92a109dbcd4e2b8c179e337848ba6a25fe16 Source-Link: googleapis/synthtool@99ea92a * chore: update jre to 11 for linter java-format requires JRE v11+ to run linter. It still check older code, just jre has to be 11+: google/google-java-format#529 Updating ci.yaml template since it is applicable for all the libraries. Source-Author: Timur Sadykov <stim@google.com> Source-Date: Tue Nov 9 01:52:34 2021 +0000 Source-Repo: googleapis/synthtool Source-Sha: 42a3786737c17ece39924d7025f3be481812da53 Source-Link: googleapis/synthtool@42a3786
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in case we decide to implement "close all owned channels" (issue #809)
cc:mziccard