FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Pub/Sub SPI: Adding IAM methods and auto-generated unit tests by garrettjonesgoogle · Pull Request #1219 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

Pub/Sub SPI: Adding IAM methods and auto-generated unit tests - #1219

Closed
garrettjonesgoogle wants to merge 1 commit into
googleapis:masterfrom
garrettjonesgoogle:master
ConversationCommits (1)ChecksFiles changed
Closed

Pub/Sub SPI: Adding IAM methods and auto-generated unit tests#1219
garrettjonesgoogle wants to merge 1 commit into
googleapis:masterfrom
garrettjonesgoogle:master

Conversation

garrettjonesgoogle commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

Note: grpc-google-pubsub-v1 depends on a new package grpc-google-iam-v1, which contains IAMPolicy and Policy.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2016

mziccard commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

A couple of questions on dependencies:

  • grpc-google-iam-v1 contains iam classes that will be used by all services, right?
  • Why does grpc-google-common-protos depend on protobuf-java 3.0.0-beta-3 instead of the latest protobuf-java 3.0.0?

garrettjonesgoogle commented Aug 31, 2016

Copy link
Copy Markdown
Contributor Author
  • yes, grpc-google-iam-v1 will be shared by multiple services.
  • I haven't updated the protobuf-java dependency in order to isolate changes. I will do a batch upgrade of grpc to 1.0.0 and protobuf to 3.0.0 in one go, without other changes at the same time.

coveralls commented Aug 31, 2016

Copy link
Copy Markdown

Coverage increased (+0.2%) to 85.434% when pulling 96f22d3 on garrettjonesgoogle:master into 7cd60df on GoogleCloudPlatform:master.

mziccard commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

@garrettjonesgoogle another general question: is there a real need for having a copy of setIamPolicy, setIamPolicy and testIamPermissions in both PublisherApi and SubscriberApi? It seems like a lot of duplicated code to me. Will other services use/require this approach as well? Did you consider putting the three methods in a dedicated PubSubIamApi class?

garrettjonesgoogle commented Sep 1, 2016

Copy link
Copy Markdown
Contributor Author

It's the general pattern for IAM. In services that follow the suggested pattern (see https://github.com/googleapis/googleapis/blob/master/google/genomics/v1/datasets.proto ), the methods are redeclared in each service declaration. This allows their documentation and http paths to be customized. Pub/Sub doesn't follow the suggested pattern in the proto declarations, although it shows up the correct way in the http view (see https://developers.google.com/apis-explorer/#p/pubsub/v1/ ).

mziccard commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

Will setting the policy for a topic resource via the SubscriberApi (or for a subscription via the PublisherApi) fail? Or is this just for having specific docs and http endpoints?

garrettjonesgoogle commented Sep 1, 2016

Copy link
Copy Markdown
Contributor Author

The way it's set up currently, it will fail validation when the flattened methods are used, but the request-based methods would not fail. The http endpoints actually have zero impact on the gRPC call; we just use the http endpoint information to inform our codegen (we derive the validation from it).

mziccard commented Sep 7, 2016

Copy link
Copy Markdown
Contributor

I am closing this, rebased on top of master in #1229

mziccard closed this Sep 7, 2016
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
b54e015 
…cies to v3.1.0 (#1219)
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
chore(main): release 3.13.5 (#1221)
1b01f94 
🤖 I have created a release *beep* *boop*
---


## [3.13.5](https://togithub.com/googleapis/java-logging/compare/v3.13.4...v3.13.5) (2022-12-06)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#1219](https://togithub.com/googleapis/java-logging/issues/1219)) ([b54e015](https://togithub.com/googleapis/java-logging/commit/b54e015b13b52bfae0f57242a08c452a74cbfb29))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
deps: update dependency com.google.cloud:google-cloud-logging to v3.1…
97f47d8 
…5.14 (#1219)
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
chore(deps): update dependency com.google.cloud:google-cloud-datastor…
7eccde3 
…e to v2.17.4 (#1219)

* chore(deps): update dependency com.google.cloud:google-cloud-datastore to v2.17.4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
chore(deps): bump guava from 31.0.1-android to 32.0.0-android (#1219)
d88ee25 
Bumps [guava](https://github.com/google/guava) from 31.0.1-android to 32.0.0-android.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
d67fb04 
…cies to v3.1.0 (googleapis#1219)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
chore(main): release 3.13.5 (googleapis#1221)
d16e1bc 
🤖 I have created a release *beep* *boop*
---


## [3.13.5](https://togithub.com/googleapis/java-logging/compare/v3.13.4...v3.13.5) (2022-12-06)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([googleapis#1219](https://togithub.com/googleapis/java-logging/issues/1219)) ([d67fb04](https://togithub.com/googleapis/java-logging/commit/d67fb04a4ccd60933a020a03494488386416bd77))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
chore(deps): bump guava from 31.0.1-android to 32.0.0-android (#1219)
4db80f0 
Bumps [guava](https://github.com/google/guava) from 31.0.1-android to 32.0.0-android.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
chore(main): release 2.9.14 (googleapis#1219)
d2a7260 
🤖 I have created a release *beep* *boop*
---


## [2.9.14](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.9.13...v2.9.14) (2023-05-02)


### Dependencies

* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.41.0 ([googleapis#1216](https://togithub.com/googleapis/java-spanner-jdbc/issues/1216)) ([5e69512](https://togithub.com/googleapis/java-spanner-jdbc/commit/5e695121f7bdbc0fa0256e7a4525f5172f1ff75b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 30, 2026
feat: Store bucket name in URI authority (#1218) (#1219)
963b3aa
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
feat: Store bucket name in URI authority (#1218) (#1219)
d440db6
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
chore(main): release 1.120.7 (#1219)
95f65ad 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
chore(main): release 1.120.7 (#1219)
de0573f 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
chore: Enable Size-Label bot in all googleapis Java repositories (goo…
cdcade4 
…gleapis#1381) (googleapis#1219)

* chore: Enable Size-Label bot in all googleapis Java repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Java repositories

* Remove product

Remove product since it is by default true

* add license header

Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>
Source-Link: googleapis/synthtool@54b2c6a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:fc52b202aa298a50a12c64efd04fea3884d867947effe2fa85382a246c09e813
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL