FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "feat(gapic-generator): Add NullMarked annotation to generated classes" by zhumin8 · Pull Request #13573 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

Revert "feat(gapic-generator): Add NullMarked annotation to generated classes" - #13573

Merged
zhumin8 merged 1 commit into
mainfrom
revert-13517-feat/jspecify-nullmarked
Jun 29, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Revert "feat(gapic-generator): Add NullMarked annotation to generated classes"#13573
zhumin8 merged 1 commit into
mainfrom
revert-13517-feat/jspecify-nullmarked

Conversation

zhumin8 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Reverts #13517

Fixes #13555

zhumin8 requested review from a team as code owners June 29, 2026 19:46
zhumin8 mentioned this pull request Jun 29, 2026
Closed
gemini-code-assist Bot reviewed Jun 29, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request removes the @NullMarked annotation and its associated org.jspecify:jspecify dependency from the GAPIC generator, generated Java client libraries, stub classes, resource names, and build configuration files (such as pom.xml and java_gapic.bzl). Golden test files have also been updated to reflect these changes. I have no feedback to provide as there are no review comments.

sonarqubecloud Bot commented Jun 29, 2026

Copy link
Copy Markdown

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud Bot commented Jun 29, 2026

Copy link
Copy Markdown

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zhumin8 enabled auto-merge (squash) June 29, 2026 20:16
zhumin8 merged commit 7bb3c35 into main Jun 29, 2026
286 of 294 checks passed
zhumin8 deleted the revert-13517-feat/jspecify-nullmarked branch June 29, 2026 20:30
lqiu96 pushed a commit that referenced this pull request Jun 30, 2026
Revert "feat(gapic-generator): Add NullMarked annotation to generated…
4462447 
… classes" (#13573)

Reverts #13517

Fixes #13555
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lqiu96 lqiu96 approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Librarian generate diff check failed on main branch

2 participants

Back | FazBrowse Home | New Git URL