FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(spanner): remove deprecated OTel GCP resource detector dependency by surbhigarg92 · Pull Request #13843 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

chore(spanner): remove deprecated OTel GCP resource detector dependency - #13843

Merged
surbhigarg92 merged 2 commits into
mainfrom
spanner_remove_detector_dep
Jul 21, 2026
ConversationCommits (2)ChecksFiles changed
Merged

chore(spanner): remove deprecated OTel GCP resource detector dependency#13843
surbhigarg92 merged 2 commits into
mainfrom
spanner_remove_detector_dep

Conversation

surbhigarg92 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

No description provided.

surbhigarg92 requested review from a team as code owners July 21, 2026 06:51
gemini-code-assist Bot reviewed Jul 21, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request replaces the dependency on com.google.cloud.opentelemetry:detector-resources-support with io.opentelemetry.contrib:opentelemetry-gcp-resources in pom.xml. Consequently, BuiltInMetricsProvider.java has been updated to use GCPResourceProvider instead of GCPPlatformDetector to detect the client's GCP location, retrieving attributes like cloud.region and cloud.availability_zone instead of the older custom keys. There are no review comments, and I have no additional feedback to provide.

surbhigarg92 force-pushed the spanner_remove_detector_dep branch 2 times, most recently from f368e48 to 65c2ed6 Compare July 21, 2026 11:24
surbhigarg92 force-pushed the spanner_remove_detector_dep branch from 65c2ed6 to 934716d Compare July 21, 2026 11:43
blakeli0 reviewed Jul 21, 2026
View reviewed changes
Comment thread java-spanner/google-cloud-spanner/pom.xml
<artifactId>opentelemetry-sdk-metrics</artifactId>
</dependency>
<dependency>
<groupId>com.google.cloud.opentelemetry</groupId>

blakeli0 Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How do you know this is deprecated? The deprecation notice from README?

cc: @mutianf We may want to remove it from Bigtable as well.

surbhigarg92 Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also this was highlighted from Otel team.
cc: @psx95

psx95 Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, it is preferred to remove dependency from this exporter. The recommendation is to move to the standard OpenTelemetry OTLP exporters.

surbhigarg92 merged commit 8baace5 into main Jul 21, 2026
210 checks passed
surbhigarg92 deleted the spanner_remove_detector_dep branch July 21, 2026 17:06
blakeli0 mentioned this pull request Jul 22, 2026
Open
mutianf pushed a commit to mutianf/google-cloud-java that referenced this pull request Jul 24, 2026
chore(spanner): remove deprecated OTel GCP resource detector dependen…
355d539 
…cy (googleapis#13843)
mutianf pushed a commit to mutianf/google-cloud-java that referenced this pull request Jul 24, 2026
chore(spanner): remove deprecated OTel GCP resource detector dependen…
1ac7613 
…cy (googleapis#13843)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

blakeli0 blakeli0 left review comments
sakthivelmanii sakthivelmanii approved these changes
+2 more reviewers
psx95 psx95 approved these changes
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL