feat(bigquery-jdbc): implement TypeRegistry and TypeDescriptor by Neenu1995 · Pull Request #13947 · googleapis/google-cloud-java · GitHub

No description provided.

Code Review

This pull request introduces BigQueryTypeRegistry and TypeDescriptor to handle bidirectional type mapping and coercion between JDBC, Java, and BigQuery. The review feedback highlights several key issues and improvements: a potential runtime exception in the TIMESTAMP coercer for Java 8 date/time types, precision loss when converting Number to BigDecimal using doubleValue(), and unused code involving DESCRIPTORS_BY_ORDINAL. Additionally, suggestions were made to expand conversion support for java.util.Date and Gson's JsonElement to make the registry more robust.

The DESCRIPTORS_BY_ORDINAL array is declared and populated but never read anywhere in the class. It should be removed to clean up unused code.

The initialization of DESCRIPTORS_BY_ORDINAL is unused and can be removed.

The registration of DESCRIPTORS_BY_ORDINAL is unused and can be removed.

…xception

/gemini review

Code Review

This pull request introduces a type mapping and coercion system between JDBC, Java, and BigQuery types, consisting of BigQueryTimezoneUtility, BigQueryTypeRegistry, and TypeDescriptor. The feedback highlights several key areas for improvement: resolving a potential parsing bug in boxTimestamp for strings with timezone offsets, using legacy Calendar manipulation for java.sql.Time to handle DST correctly, preserving millisecond precision when converting to LocalTime, and removing the unused DESCRIPTORS_BY_ORDINAL array.

Why do we need a fallback? Shouldn't we implement all possible conversions?

We need the STRING fallback to preserve backward compatibility and prevent crashing legacy applications that rely on the driver's old behavior of silently stringifying unmapped objects so the BigQuery backend can parse them.

/gcprun

nit: I'd add overrides without ZoneId. It is used only with date/time objects, but we have a lot of other conversions where zone is unused.

So this is where I'm not 100% sure about the behavior.

We have 4 time-related types: timestamp, time, date, datetime.

Time, Date, Datetime are not timezone specific, so we should be reading them as-is. If it is stored as "12:30:00", it should remain "12:30:00" regardless of the JVM timezone or provided timezone.

Timestamp is the only value that needs to be adjusted to the timezone.

java.sql.Date stores epoch millis under the hood, not civil year/month/day fields.
getDate(col, cal) contract: Per JDBC spec, the returned java.sql.Date must represent midnight (00:00:00) in the provided Calendar's timezone.
Prevents date shifting: Without anchoring to midnight in the target timezone, formatting or reading the date in that timezone would shift it to the wrong day (e.g., UTC midnight 2026-07-17 displays as 2026-07-16 20:00 in New York time).

(Note: Modern LocalDate via getObject(col, LocalDate.class) is already timezone-agnostic and read as-is without any conversion).

Returned Class / Method	Underlying Representation	Timezone Handling
getObject(col, LocalDate.class)	java.time.LocalDate	As-is (completely timezone-agnostic)
getObject(col, LocalTime.class)	java.time.LocalTime	As-is (completely timezone-agnostic)
getDate(col)	java.sql.Date	Anchored to 00:00:00 in JVM default timezone
getDate(col, Calendar cal)	java.sql.Date	Anchored to 00:00:00 in target Calendar timezone
getTimestamp(col, Calendar cal)	java.sql.Timestamp	Absolute instant adjusted to target Calendar timezone

🤖 I have created a release *beep* *boop* --- <details><summary>1.90.0</summary> ## [1.90.0](v1.89.0...v1.90.0) (2026-08-24) ### Features * **bigquery-jdbc:** implement TypeRegistry and TypeDescriptor ([#13947](#13947)) ([0557e69](0557e69)) * **bigquery:** add QueryResultsFormat and ArrowSerializationOptions configurations ([#13942](#13942)) ([ff03e19](ff03e19)) * **bigquery:** expose `StatementType` and query execution stats on `TableResult` ([#14145](#14145)) ([7d16de8](7d16de8)) * **bigtable:** enable microsecond timestamps in client ([#14057](#14057)) ([57aaf8d](57aaf8d)) * **bigtable:** route single-entry MutateRows through a point-write c… ([#14028](#14028)) ([a403703](a403703)) * **datastore:** add support for request tags ([#13732](#13732)) ([b1f6186](b1f6186)) * **ftp:** onboard a new library ([#14068](#14068)) ([f41b2d9](f41b2d9)) * **gax:** add ResumableUploadCallable and ResumableUploadCallSettings ([#14052](#14052)) ([a5e26e8](a5e26e8)) * **google/cloud/biglake/hive/v1:** onboard a new library ([#14130](#14130)) ([650c839](650c839)) * **google/maps/mapmanagement/v2:** onboard a new library ([#14131](#14131)) ([7d00726](7d00726)) * **spanner:** support user-provided OpenTelemetry for client metrics export ([#13741](#13741)) ([da74dee](da74dee)) * update API sources and regenerate ([#14000](#14000)) ([9337a93](9337a93)) * **workloadidentity:** onboard a new library ([#14060](#14060)) ([ab226ee](ab226ee)) ### Bug Fixes * add documentation for insertall api that there's no default retry ([#13953](#13953)) ([1fdb4f1](1fdb4f1)) * add retry behavior documentation to insertall interface to clarify the behavior ([#14058](#14058)) ([1b8f9e3](1b8f9e3)) * **auth:** fix JSpecify nullability in UserAuthorizer and TokenStore ([#14150](#14150)) ([0d5fac0](0d5fac0)) * **auth:** fix remaining nullability in UserAuthorizer and Builder ([#14158](#14158)) ([a51bb8d](a51bb8d)) * **auth:** refine JSpecify nullability for ServiceAccountCredentials and UserCredentials ([#14159](#14159)) ([a929250](a929250)) * **bigquery-jdbc:** enable ITOpenTelemetryTest ([#13991](#13991)) ([fa6641b](fa6641b)) * **bigquery-jdbc:** pass connection proxy settings to OpenTelemetry exporters ([#14011](#14011)) ([115b9b3](115b9b3)) * **bigquery-jdbc:** session context propagation when session is enabled ([#14161](#14161)) ([1e74dda](1e74dda)) * **bigtable:** remove heartbeat miss logging ([#14054](#14054)) ([ec17637](ec17637)) * **deps:** update dependency com.google.apis:google-api-services-bigquery to v2-rev20260731-2.0.0 ([#14149](#14149)) ([95f6c38](95f6c38)) * **deps:** update dependency com.google.cloud:libraries-bom to v26.86.0 ([#14103](#14103)) ([cf5697e](cf5697e)) * **gax-httpjson:** reduce Conscrypt fallback error to debug level ([#13962](#13962)) ([8236771](8236771)) * **gax-httpjson:** remove unsupported and deprecated PQC named groups ([#14107](#14107)) ([7604971](7604971)) * **gax:** register Conscrypt SSLContext SPI classes for GraalVM reflection ([#14129](#14129)) ([73c0243](73c0243)) * **samples:** align native profile junit and surefire versions with shared config ([#14096](#14096)) ([2b84133](2b84133)) * **spanner:** add closeAsync to ReadContext and make transaction closing non-blocking ([#14076](#14076)) ([671f892](671f892)) * **spanner:** scope server-timing metrics per call and guard interceptor lifecycle callbacks ([#14053](#14053)) ([f35c570](f35c570)) * **storage:** use JsonUtils for StorageObject serialization in resumable writes and read channels ([#13976](#13976)) ([d94922f](d94922f)) ### Performance Improvements * **bigquery-jdbc:** eliminate dry run to resolve statement type ([#14156](#14156)) ([7109ecd](7109ecd)) * **spanner-jdbc:** cache commonly used query parameter names ([#14036](#14036)) ([1eb6aa3](1eb6aa3)) * **spanner-jdbc:** cache JDBC metadata query strings ([#14041](#14041)) ([31c628f](31c628f)) * **spanner-jdbc:** cache positional to named param conversion ([#14034](#14034)) ([30e031b](30e031b)) ### Dependencies * **gax-httpjson:** upgrade conscrypt-openjdk-uber to 2.6.2 ([#14117](#14117)) ([2f5481a](2f5481a)) * Update gRPC to v1.82.3 ([#13997](#13997)) ([a786107](a786107)) * Upgrade gRPC to v1.82.4 ([#14088](#14088)) ([0c482fe](0c482fe)) ### Documentation * **bigquery-jdbc:** add user guide with connection property and custom endpoint reference ([#13878](#13878)) ([2dde172](2dde172)) * **gax:** update LRO troubleshooting documentation link ([#14108](#14108)) ([4c5bbae](4c5bbae)) * **spanner-jdbc:** update connection_properties.md documentation ([#14035](#14035)) ([b576fe8](b576fe8)) * **spanner:** update CHANGELOG.md for releases 6.117.0 through 6.120.0 ([#13970](#13970)) ([2413811](2413811)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

feat(bigquery-jdbc): implement TypeRegistry and TypeDescriptor

436c18e

Neenu1995 requested review from a team as code owners July 29, 2026 16:44

fix(bigquery-jdbc): restrict visibility to package-private

efb8327

gemini-code-assist Bot reviewed Jul 29, 2026

View reviewed changes

Neenu1995 added 4 commits July 29, 2026 13:02

redesign TypeRegistry

c23e0ce

fix(bigquery-jdbc): use BigQueryJdbcException instead of generic SQLE…

657852f

…xception

lint

62800cf

timeZoneUtility

94fd293

gemini-code-assist Bot reviewed Jul 29, 2026

View reviewed changes

feat: core type registry matrix (Phase 1)

536df8b

logachev reviewed Jul 30, 2026

View reviewed changes

refactor the static block

69aaa79

Neenu1995 requested a review from logachev July 30, 2026 16:59

lint

83803da

logachev reviewed Aug 6, 2026

View reviewed changes

logachev approved these changes Aug 6, 2026

View reviewed changes

Neenu1995 merged commit 0557e69 into main Aug 7, 2026
206 checks passed

Neenu1995 deleted the feat/type-registry-phase-1 branch August 7, 2026 17:47

jinseopkim0 pushed a commit that referenced this pull request Aug 7, 2026

feat(bigquery-jdbc): implement TypeRegistry and TypeDescriptor (#13947 )

1431880

This was referenced Aug 19, 2026

chore(main): release 1.90.0 #14120

Closed

chore(main): release 1.90.0 #14126

Closed

chore(main): release 1.90.0 #14148

Closed

chore(main): release 1.90.0 #14169

Closed

chore(main): release 1.90.0 #14173

Merged

+                  int maxOrdinal = 0;
+                  for (StandardSQLTypeName type : StandardSQLTypeName.values()) {
+                    if (type.ordinal() > maxOrdinal) {
+                      maxOrdinal = type.ordinal();
+                    }
+                  }
+                  DESCRIPTORS_BY_ORDINAL = new TypeDescriptor<?>[maxOrdinal + 1];

+                 * High-performance hotpath convert for ResultSets. Converts the input value using the default
+                 * mapping for the given BigQuery type via O(1) array indexing.
+                 */
+                public static Object convert(Object input, StandardSQLTypeName bqType, ZoneId zoneId)

+               */
+              final class BigQueryTypeRegistry {
+                private static final TypeDescriptor<?>[] DESCRIPTORS_BY_ORDINAL;

+                  if (DESCRIPTORS_BY_ORDINAL[descriptor.getBqType().ordinal()] == null) {
+                    DESCRIPTORS_BY_ORDINAL[descriptor.getBqType().ordinal()] = descriptor;
+                  }

+                /**
+                 * Returns the exact BigQuery StandardSQLTypeName for a given Java class. If no mapping is found,
+                 * returns StandardSQLTypeName.STRING as a fallback.

+                /**
+                 * Converts a BigQuery civil DATE string into an absolute Date by anchoring it to midnight of the
+                 * provided timezone (or JVM default if null).

feat(bigquery-jdbc): implement TypeRegistry and TypeDescriptor by Neenu1995 · Pull Request #13947 · googleapis/google-cloud-java · GitHub

Uh oh!

feat(bigquery-jdbc): implement TypeRegistry and TypeDescriptor - #13947

feat(bigquery-jdbc): implement TypeRegistry and TypeDescriptor#13947Neenu1995 merged 9 commits intomaingoogleapis/google-cloud-java:mainfrom feat/type-registry-phase-1googleapis/google-cloud-java:feat/type-registry-phase-1Copy head branch name to clipboard

Conversation

Neenu1995 commented Jul 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

Neenu1995 commented Jul 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

logachev Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Neenu1995 Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Neenu1995 commented Jul 30, 2026

Uh oh!

logachev Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

logachev Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

Neenu1995 Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(bigquery-jdbc): implement TypeRegistry and TypeDescriptor#13947
Neenu1995 merged 9 commits into
mainfrom
feat/type-registry-phase-1