FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(gax): add ResumableUploadStatus and ResumableUploadProgressListener by whowes · Pull Request #14073 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

feat(gax): add ResumableUploadStatus and ResumableUploadProgressListener - #14073

Closed
whowes wants to merge 1 commit into
mainfrom
whowes/resumable-upload-status
ConversationCommits (1)ChecksFiles changed
Closed

feat(gax): add ResumableUploadStatus and ResumableUploadProgressListener#14073
whowes wants to merge 1 commit into
mainfrom
whowes/resumable-upload-status

Conversation

whowes commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

These classes will provide library users a mechanism to track resumable upload progress.

gemini-code-assist Bot reviewed Aug 14, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces a new resumable upload progress tracking API, including the ResumableUploadProgressListener interface, the ResumableUploadStatus AutoValue class, and comprehensive unit tests. The feedback suggests adding a package-private constructor to ResumableUploadStatus to prevent external subclassing and preserve immutability.

Comment thread ...ava/gax-java/gax/src/main/java/com/google/api/gax/resumableupload/ResumableUploadStatus.java
@BetaApi
@NullMarked
@AutoValue
public abstract class ResumableUploadStatus {

gemini-code-assist Bot Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To prevent users from subclassing this AutoValue class outside of the package (which could bypass the immutability guarantees), it is a best practice to define a package-private constructor.

Suggested change
public abstract class ResumableUploadStatus {
public abstract class ResumableUploadStatus {
ResumableUploadStatus() {}

sonarqubecloud Bot commented Aug 14, 2026

Copy link
Copy Markdown

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud Bot commented Aug 14, 2026

Copy link
Copy Markdown

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

whowes closed this Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL