fix(spanner): Add credential check for built-in metrics enabling - #14095
fix(spanner): Add credential check for built-in metrics enabling#14095zdu-strong wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request updates SpannerOptions.java to ensure that gRPC metrics are only enabled when built-in metrics are enabled and the configuration does not use 'no credentials' (!usesNoCredentials()). As there are no review comments, I have no feedback to provide.
Sorry, something went wrong.
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
Issue: The original logic for checking whether to enable built-in metrics (enableBuiltInMetrics) lacked a credential check. This caused telemetry data to still be sent when using the Spanner emulator, which does not require credentials.
Solution: In the enableRPCMetrics method, update the condition to isEnableBuiltInMetrics() && !usesNoCredentials(), so that metric collection is properly skipped when a credential-free environment (such as the emulator) is detected.
issues 12277: Disable native metrics in connection
issues 13038: Do not print exceptions from metric export failures by default