FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(gax): add StringHttpResponseParser by whowes · Pull Request #14135 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

feat(gax): add StringHttpResponseParser - #14135

Open
whowes wants to merge 1 commit into
whowes/http-content-supportfrom
whowes/string-http-response-parser
ConversationCommits (1)ChecksFiles changed
Open

feat(gax): add StringHttpResponseParser#14135
whowes wants to merge 1 commit into
whowes/http-content-supportfrom
whowes/string-http-response-parser

Conversation

whowes commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently gax-httpjson includes only one HTTP response parser (ProtoMessageResponseParser) which assumes response bodies can be parsed into protos.

Resumable upload HTTP operations will return non-proto responses (including empty response bodies where all metadata is exchanged via headers/return code) so we'll need a more general response parser to be able to use the existing HTTP stack to talk to the upload service.

gemini-code-assist Bot reviewed Aug 19, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces StringHttpResponseParser, a new implementation of HttpResponseParser that reads HTTP response bodies as UTF-8 strings. It also includes a comprehensive suite of unit tests in StringHttpResponseParserTest covering successful parsing from input streams and readers, empty inputs, error handling, and serialization. I have no further feedback to provide as the implementation is clean and well-tested.

whowes changed the title whowes/string http response parser feat(gax): add StringHttpResponseParser Aug 19, 2026
whowes force-pushed the whowes/string-http-response-parser branch from a5e2a65 to a5a48c7 Compare August 21, 2026 00:37
whowes marked this pull request as ready for review August 21, 2026 21:57
whowes requested review from a team as code owners August 21, 2026 21:57
whowes requested a review from blakeli0 August 21, 2026 21:57
whowes force-pushed the whowes/string-http-response-parser branch from a5a48c7 to 57dcd81 Compare August 24, 2026 19:40

sonarqubecloud Bot commented Aug 24, 2026

Copy link
Copy Markdown

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud Bot commented Aug 24, 2026

Copy link
Copy Markdown

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

blakeli0 Awaiting requested review from blakeli0
1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL