FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor(gax): add startUnaryCall to HttpJsonClientCalls by whowes · Pull Request #14136 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

refactor(gax): add startUnaryCall to HttpJsonClientCalls - #14136

Draft
whowes wants to merge 1 commit into
whowes/string-http-response-parserfrom
whowes/start-unary-call
ConversationCommits (1)ChecksFiles changed
Draft

refactor(gax): add startUnaryCall to HttpJsonClientCalls#14136
whowes wants to merge 1 commit into
whowes/string-http-response-parserfrom
whowes/start-unary-call

Conversation

whowes commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

HttpJsonClientCalls currently allows callers access to the HTTP response body. The newly-added startUnaryCall allows callers to provide a Listener that allows action based on status codes and headers, both of which are needed for resumable uploads.

gemini-code-assist Bot reviewed Aug 19, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request refactors HttpJsonClientCalls.java by extracting the logic for starting a unary call from futureUnaryCall into a new helper method, startUnaryCall. This new method accepts a custom HttpJsonClientCall.Listener parameter, allowing for more flexible call handling, while futureUnaryCall is updated to delegate to this helper. There are no review comments, and I have no feedback to provide.

whowes changed the title whowes/start unary call feat(gax): add StringHttpResponseParser Aug 19, 2026
whowes changed the title feat(gax): add StringHttpResponseParser refactor(gax): add startUnaryCall to HttpJsonClientCalls Aug 19, 2026
whowes force-pushed the whowes/start-unary-call branch from abf6f55 to 37eaf01 Compare August 21, 2026 00:37
whowes force-pushed the whowes/start-unary-call branch from 37eaf01 to 51d3a10 Compare August 24, 2026 19:40

sonarqubecloud Bot commented Aug 24, 2026

Copy link
Copy Markdown

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

sonarqubecloud Bot commented Aug 24, 2026

Copy link
Copy Markdown

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL