feat(gax): add ResumableUploadClient.startUpload() and supporting types - #14138
feat(gax): add ResumableUploadClient.startUpload() and supporting types#14138whowes wants to merge 1 commit into
Conversation
Sorry, something went wrong.
This comment was marked as outdated.
|
/gemini review |
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request introduces low-level resumable upload components to the GAX library, including the ResumableUploadClient interface, the ResumableUploadSession metadata class, and the StartUploadRequest configuration class, along with their corresponding unit tests. The reviewer's feedback suggests a minor readability and performance improvement in StartUploadRequest.Builder to assign the result of getPath() to a local variable instead of invoking the getter multiple times.
Sorry, something went wrong.
| if (getPath() != null && getPath().startsWith("/")) { | ||
| setPath(getPath().substring(1)); | ||
| } |
There was a problem hiding this comment.
To improve readability and avoid redundant getter calls on the builder, assign the result of getPath() to a local variable before performing null checks and string manipulations.
| if (getPath() != null && getPath().startsWith("/")) { | |
| setPath(getPath().substring(1)); | |
| } | |
| String path = getPath(); | |
| if (path != null && path.startsWith("/")) { | |
| setPath(path.substring(1)); | |
| } |
Sorry, something went wrong.
|
Sorry, something went wrong.
|
Sorry, something went wrong.
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
HTTP/JSON client implementation for startUpload is in #14139.