FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: remove flatten plugin downstream check by lqiu96 · Pull Request #14175 · googleapis/google-cloud-java · GitHub

ci: remove flatten plugin downstream check - #14175

Merged
lqiu96 merged 1 commit into
mainfrom
fix_ci_workflow_14169
Aug 24, 2026
Merged

ci: remove flatten plugin downstream check#14175
lqiu96 merged 1 commit into
mainfrom
fix_ci_workflow_14169

Conversation

lqiu96 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Remove flatten-plugin-check job from java-shared-config-downstream-dependencies workflow, client-library-check.sh, and delete java-storage-expected-flattened-dependencies.txt.

Fixes: #13965

lqiu96 requested a review from blakeli0 August 24, 2026 18:55
lqiu96 requested review from a team as code owners August 24, 2026 18:55

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request removes the flatten-plugin step from the .kokoro/client-library-check.sh script and deletes the associated expected dependencies list file. There are no review comments, so I have no feedback to provide.

Remove flatten-plugin-check job from java-shared-config-downstream-dependencies workflow, client-library-check.sh, and delete java-storage-expected-flattened-dependencies.txt.
lqiu96 force-pushed the fix_ci_workflow_14169 branch from 0618ed5 to d6d4121 Compare August 24, 2026 19:10
lqiu96 enabled auto-merge (squash) August 24, 2026 19:11

blakeli0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. For posterity, this check was added a few years ago due to a flatten plugin bug. We don't proactively upgrade the flatten plugin version anymore, so it's OK to remove it to reduce toil.

lqiu96 merged commit be87565 into main Aug 24, 2026
197 checks passed
lqiu96 deleted the fix_ci_workflow_14169 branch August 24, 2026 20:49
lqiu96 added the release-please:force-run To run release-please label Aug 24, 2026
release-please Bot removed the release-please:force-run To run release-please label Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate ongoing value of flatten-plugin-check

2 participants


Back | FazBrowse Home | New Git URL