remove ListenableFuture from surface by pongad · Pull Request #1599 · googleapis/google-cloud-java · GitHub

This won't compile yet, since it needs change in gax:
googleapis/gax-java#200

This won't compile yet, since it needs change in gax: googleapis/gax-java#198

LGTM after the new GAX is released and the tests pass

In the future I think it would be easier to do a PR first against api-client-staging, and then against google-cloud-java.

LGTM

Coverage decreased (-0.03%) to 83.424% when pulling 900effe on pongad:listenable into fa0720c on GoogleCloudPlatform:master.

#1599) * chore: Update generation configuration at Wed Sep 25 02:24:24 UTC 2024 * update gen script * chore: generate libraries at Wed Sep 25 23:31:54 UTC 2024 * chore: Update generation configuration at Thu Sep 26 02:23:26 UTC 2024 * chore: Update generation configuration at Fri Sep 27 02:23:56 UTC 2024 * chore: Update generation configuration at Sat Sep 28 02:22:38 UTC 2024 --------- Co-authored-by: Joe Wang <joewa@google.com>

…v3.56.1 (#1599) Co-authored-by: Jin Seop Kim <1007sky@gmail.com>

…3.50.0 (#1599)

…v3.56.1 (#1599) Co-authored-by: Jin Seop Kim <1007sky@gmail.com>

…v3.49.0 (#1599)

…27.0 (#1599) * deps: update dependency com.google.cloud:google-cloud-bigquery to v2.27.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

… to v2.18.2 (googleapis#1599) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigtable](https://togithub.com/googleapis/java-bigtable) | `2.18.1` -> `2.18.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigtable/2.18.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigtable/2.18.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigtable/2.18.2/compatibility-slim/2.18.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigtable/2.18.2/confidence-slim/2.18.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigtable</summary> ### [`v2.18.2`](https://togithub.com/googleapis/java-bigtable/blob/HEAD/CHANGELOG.md#2182-httpsgithubcomgoogleapisjava-bigtablecomparev2181v2182-2023-01-24) [Compare Source](https://togithub.com/googleapis/java-bigtable/compare/v2.18.1...v2.18.2) ##### Dependencies - Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.10.0 ([#&googleapis#8203;1597](https://togithub.com/googleapis/java-bigtable/issues/1597)) ([8712f4e](https://togithub.com/googleapis/java-bigtable/commit/8712f4eca65ee6a4eb3ac3b2c9bed757b54ee4dd)) - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.2 ([#&googleapis#8203;1595](https://togithub.com/googleapis/java-bigtable/issues/1595)) ([8964f91](https://togithub.com/googleapis/java-bigtable/commit/8964f9150cb8fa5b419d5025a4ae77f27f7837cf)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigtable).

DO NOT COMMIT: remove ListenableFuture from surface

6117aff

This won't compile yet, since it needs change in gax: googleapis/gax-java#198

pongad requested a review from garrettjonesgoogle February 8, 2017 03:58

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2017

garrettjonesgoogle reviewed Feb 8, 2017

View reviewed changes

pongad added 2 commits February 9, 2017 16:10

Merge branch 'master' into listenable

8b5be7a

pr comment

15ded7e

garrettjonesgoogle reviewed Feb 9, 2017

View reviewed changes

pr comment

900effe

pongad merged commit f8a7867 into googleapis:master Feb 9, 2017

pongad deleted the listenable branch February 9, 2017 23:48

pongad changed the title DO NOT COMMIT: remove ListenableFuture from surface remove ListenableFuture from surface Feb 9, 2017

chingor13 pushed a commit that referenced this pull request Feb 12, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

e021fd8

…v3.56.1 (#1599) Co-authored-by: Jin Seop Kim <1007sky@gmail.com>

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

chore(deps): update dependency com.google.cloud:google-iam-admin to v…

bc9e057

…3.50.0 (#1599)

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

chore(deps): update dependency com.google.cloud:google-iam-admin to v…

493696c

…3.50.0 (#1599)

lqiu96 pushed a commit that referenced this pull request Mar 20, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

b4b0b82

…v3.56.1 (#1599) Co-authored-by: Jin Seop Kim <1007sky@gmail.com>

suztomo pushed a commit that referenced this pull request Mar 30, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

2c94566

…v3.49.0 (#1599)

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

df1320d

…v3.49.0 (#1599)

-                void receiveMessage(final PubsubMessage message, final SettableFuture<AckReply> response);
+                interface AckReplyConsumer {
+                  void accept(AckReply ackReply, Throwable t);
+                }

+                 * Accepts a reply, sending it to the service.
+                 *
+                 * <p>Both the interface and its method is named after the Java 8's {@code BiConsumer} interface
+                 * to ease migration when we finally move.

+                  return new ListenableFutureDelegate<String>(publishResult);
+                }
+                private static class ListenableFutureDelegate<V> extends SimpleForwardingListenableFuture<V>

+              package com.google.cloud.pubsub.spi.v1;
+              /**
+               * Used by {@link MessageReceiver}, {@code AckReplyConsumer} accepts an {@link MessageReceiver.AckReply}, sending it to the service.

remove ListenableFuture from surface by pongad · Pull Request #1599 · googleapis/google-cloud-java · GitHub

Uh oh!

remove ListenableFuture from surface - #1599

remove ListenableFuture from surface#1599pongad merged 4 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom pongad:listenableCopy head branch name to clipboard

Conversation

pongad commented Feb 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Feb 9, 2017

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Feb 9, 2017

Uh oh!

garrettjonesgoogle commented Feb 9, 2017

Uh oh!

coveralls commented Feb 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

remove ListenableFuture from surface#1599
pongad merged 4 commits into
googleapis:masterfrom
pongad:listenable

pongad commented Feb 8, 2017 •
edited
Loading