pubsub: new publish snippet - #1608
Merged
pongad merged 6 commits intoFeb 21, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Changes Unknown when pulling 561e792 on pongad:pubsub-snippets into ** on GoogleCloudPlatform:master**. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Changes Unknown when pulling a727b8c on pongad:pubsub-snippets into ** on GoogleCloudPlatform:master**. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM, but wait for @lesv to review and don't merge before Tue PST. |
Sorry, something went wrong.
lesv
suggested changes
Feb 14, 2017
Comment thread
...loud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java
Outdated
| public void publish(String projectName, String topicName) throws Exception { | ||
| // [START publish] | ||
| Publisher publisher = Publisher.newBuilder(TopicName.create(projectName, topicName)).build(); | ||
| List<String> messages = Arrays.asList("message1", "message2"); |
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@lesv PTAL. I'm not 100% sure I understand you correctly, but please let me know if this looks better. I also wanted to make sure the sample for creating the publisher also shuts it down. There're lots of threads to leak if you forget. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Changes Unknown when pulling 613b96b on pongad:pubsub-snippets into ** on GoogleCloudPlatform:master**. |
Sorry, something went wrong.
lesv
approved these changes
Feb 14, 2017
Comment thread
...loud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java
| */ | ||
| // [TARGET publish(PubsubMessage)] | ||
| // [VARIABLE "my_message"] | ||
| public void publish(String message) { |
This comment was marked as spam.
Comment thread
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java
Outdated
| * are encouraged to provide instances of {@code ChannelProvider} that creates new channels | ||
| * instead of returning pre-initialized ones. | ||
| * | ||
| * <p>Example of creating a {@code Publisher}. |
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@lesv PTAL. Looks like the snippet-insertion script doesn't work well with one-line comments or something. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Changes Unknown when pulling 2578db3 on pongad:pubsub-snippets into ** on GoogleCloudPlatform:master**. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Changes Unknown when pulling b40af57 on pongad:pubsub-snippets into ** on GoogleCloudPlatform:master**. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Changes Unknown when pulling b40af57 on pongad:pubsub-snippets into ** on GoogleCloudPlatform:master**. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM with the understanding that tests will come next |
Sorry, something went wrong.
lesv
approved these changes
Feb 21, 2017
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
* fix: An existing method `UpdateVehicleLocation` is removed from service `VehicleService` fix: An existing method `SearchFuzzedVehicles` is removed from service `VehicleService` fix: An existing message `UpdateVehicleLocationRequest` is removed PiperOrigin-RevId: 631557549 Source-Link: googleapis/googleapis@3d50414 Source-Link: https://github.com/googleapis/googleapis-gen/commit/5ce63d4e636a975175bde2d16c15e70dd5a81ff4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWNlNjNkNGU2MzZhOTc1MTc1YmRlMmQxNmMxNWU3MGRkNWE4MWZmNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
…#1608) * chore: Update generation configuration at Tue Oct 1 02:27:19 UTC 2024 * chore: generate libraries at Tue Oct 1 02:27:43 UTC 2024 * chore: Update generation configuration at Wed Oct 2 02:23:35 UTC 2024 * chore: Update generation configuration at Thu Oct 3 02:23:49 UTC 2024 * chore: Update generation configuration at Fri Oct 4 02:23:55 UTC 2024 * chore: generate libraries at Fri Oct 4 02:24:21 UTC 2024 * chore: Update generation configuration at Sat Oct 5 02:26:12 UTC 2024 * chore: Update generation configuration at Sun Oct 6 02:25:59 UTC 2024 * chore: generate libraries at Sun Oct 6 02:26:25 UTC 2024 * chore: Update generation configuration at Tue Oct 8 02:25:05 UTC 2024 * chore: generate libraries at Tue Oct 8 02:25:30 UTC 2024 * chore: Update generation configuration at Wed Oct 9 02:23:35 UTC 2024
chingor13
pushed a commit
that referenced
this pull request
Feb 24, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
* fix: An existing method `UpdateVehicleLocation` is removed from service `VehicleService` fix: An existing method `SearchFuzzedVehicles` is removed from service `VehicleService` fix: An existing message `UpdateVehicleLocationRequest` is removed PiperOrigin-RevId: 631557549 Source-Link: googleapis/googleapis@3d50414 Source-Link: https://github.com/googleapis/googleapis-gen/commit/5ce63d4e636a975175bde2d16c15e70dd5a81ff4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWNlNjNkNGU2MzZhOTc1MTc1YmRlMmQxNmMxNWU3MGRkNWE4MWZmNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 12, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
Remove the open-telemetry dependency import, as it is already defined in the shared dependencies.
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
🤖 I have created a release *beep* *boop* --- ## [2.18.1](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.18.0...v2.18.1) (2024-05-22) ### Dependencies * Remove open-telemetry dependency import ([googleapis#1608](https://togithub.com/googleapis/java-spanner-jdbc/issues/1608)) ([b567d7a](https://togithub.com/googleapis/java-spanner-jdbc/commit/b567d7a61dbce3e2e2542b85a1889f463426446a)) * Update dependency com.google.cloud:google-cloud-spanner-bom to v6.67.0 ([googleapis#1613](https://togithub.com/googleapis/java-spanner-jdbc/issues/1613)) ([64a72d4](https://togithub.com/googleapis/java-spanner-jdbc/commit/64a72d42ab577e8e32335422d4bea23bbdc60815)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.30.1 ([googleapis#1609](https://togithub.com/googleapis/java-spanner-jdbc/issues/1609)) ([389e174](https://togithub.com/googleapis/java-spanner-jdbc/commit/389e174c8d4a9a3ebebfd233978b793b55b537d8)) * Update dependency io.opentelemetry:opentelemetry-bom to v1.38.0 ([googleapis#1606](https://togithub.com/googleapis/java-spanner-jdbc/issues/1606)) ([6a6b912](https://togithub.com/googleapis/java-spanner-jdbc/commit/6a6b91223b855972659108bc479c226b8b60ebea)) * Update dependency org.springframework.data:spring-data-bom to v2023.1.6 ([googleapis#1610](https://togithub.com/googleapis/java-spanner-jdbc/issues/1610)) ([2da6a4c](https://togithub.com/googleapis/java-spanner-jdbc/commit/2da6a4c8cfa0b947a7fe4bab91bd56d9b1427d1a)) * Update dependency org.springframework.data:spring-data-bom to v2024 ([googleapis#1611](https://togithub.com/googleapis/java-spanner-jdbc/issues/1611)) ([abc482b](https://togithub.com/googleapis/java-spanner-jdbc/commit/abc482b790e7013067aa2d6cf2816cd78e9e1f34)) * Update dependency org.testcontainers:testcontainers to v1.19.8 ([googleapis#1604](https://togithub.com/googleapis/java-spanner-jdbc/issues/1604)) ([dd2b60f](https://togithub.com/googleapis/java-spanner-jdbc/commit/dd2b60f3effe8bafa7bef81c626fde6f41f0d5e3)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 30, 2026
lqiu96
pushed a commit
that referenced
this pull request
Apr 1, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
…6.0 (googleapis#1608) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.6.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the subscriber side soon to follow