logging: remove handler's buffer - #1796
Merged
pongad merged 1 commit intoMar 24, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
LoggingHandler's buffer is redundant, since it's already using the batching feature. LoggingHandler.flush previously just flushes its own buffer and put messages in the batcher's buffer, without necessarily making RPC calls. This PR does not fix this problem, but it makes flush obviously wrong instead of subtly. The test for flush size is also removed. Flush size should be forwareded to the batcher, which already has its own test. Updates #1795.
garrettjonesgoogle
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
| buffer = new LinkedList<>(); | ||
| } | ||
| if (entry != null) { | ||
| write(entry, writeOptions); |
This comment was marked as spam.
This comment was marked as spam.
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
🤖 I have created a release *beep* *boop* --- ## [3.22.2](https://togithub.com/googleapis/java-logging/compare/v3.22.1...v3.22.2) (2025-04-25) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.46.2 ([#1796](https://togithub.com/googleapis/java-logging/issues/1796)) ([1f88271](https://togithub.com/googleapis/java-logging/commit/1f882712aeb7e48a2339ffbad783813e11e74401)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
🤖 I have created a release *beep* *boop* --- ## [3.22.2](https://togithub.com/googleapis/java-logging/compare/v3.22.1...v3.22.2) (2025-04-25) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.46.2 ([googleapis#1796](https://togithub.com/googleapis/java-logging/issues/1796)) ([07d6399](https://togithub.com/googleapis/java-logging/commit/07d63995a0034fba3538ceac56aae869b7fdbfbb)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
…-info-reports-plugin to v3.8.0 (googleapis#1796)
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
* feat: migrate to OTEL exporter (googleapis#1788) * feat: migrate exporter to OTEL * address comments * filter out only bigtable metrics * fix test * use the bom * update * update * update completeResultCode * add a comment * address comments * address comments * update pom * small fix * also check timestamp * address comment * updates * update * do not block on shutdown * chore: refactor factory class (googleapis#2081) * chore: refactor TracerFactory creation (googleapis#2102) * feat: migrate built in metrics to OTEL (googleapis#1796) * feat: migrate exporter to OTEL * address comments * filter out only bigtable metrics * fix test * use the bom * update * update * feat: migrate builtin metrics to OTEl * update completeResultCode * add a comment * udpate * fix tests * remove unrelated changes * fix tests * add documentation * fix test * merge exporter changes * address comments * rebase on otel * revert changes in stats * fix import * update * merge back the endpoint change * refactor constants and settings * refactor and fix tests * remove unused dependency * add some javadoc * address part of the comments * update test * test with nano * measure everything in nanos and publish with double histogram * address comments * fix test * add toString * merge from main * feat: migrate per connection error count metric to otel (googleapis#2133) * feat: migrate per connection error count metric to otel * update test * address comments * remove unnecessary check * clean up statsRecorder * remove dependency * address comments * feat: migrate per connection error exporter to otel (googleapis#2152) * chore: clean up stats package (googleapis#2163) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix clirr and integration test * fix clirr and integration test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * log more information on test failures * address comments * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * include version * fix flaky test * remove otel dependencies since they're added to shared dependencies * backport new tests since 2.37 * set feature flag when metrics is enabled * record metrics whenever it's registered * record metrics whenever it's registered * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * remove stale reference * clean up --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoggingHandler's buffer is redundant,
since it's already using the batching feature.
LoggingHandler.flush previously just flushes its own buffer
and put messages in the batcher's buffer,
without necessarily making RPC calls.
This PR does not fix this problem,
but it makes flush obviously wrong instead of subtly.
The test for flush size is also removed.
Flush size should be forwareded to the batcher,
which already has its own test.
Updates #1795.