Make sure Storage does not do name normalization - #1908
Closed
shinfan wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, I'm on vacation until Tuesday so I probably won't be able to review this until then. |
Sorry, something went wrong.
Comment thread
google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java
Outdated
| @Test | ||
| public void testBlobNameNormalization() { | ||
| for (String blobName : BLOB_NORMALIZATION.keySet()) { | ||
| BlobInfo blobInfoFormC = BlobInfo.newBuilder(BlobId.of(BUCKET, blobName)) |
This comment was marked as spam.
This comment was marked as spam.
jskeet
reviewed
Apr 19, 2017
Comment thread
google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java
Outdated
| .setContentType("text/plain") | ||
| .setContentEncoding("UTF-8") | ||
| .build(); | ||
| Blob blob = storage.create(blobInfo, BLOB_NORMALIZATION.get(blobName).getBytes()); |
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
Oops I updated this branch by mistake. I will fix this. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Changes Unknown when pulling b37a624 on shinfan:master into ** on GoogleCloudPlatform:master**. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@shinfan could you maybe create a PR off of a different branch so that it isn't prone to getting overwritten? |
Sorry, something went wrong.
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
…p/templates/java_library/.kokoro (#1908) (#1491) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Jan 6, 2026
…p/templates/java_library/.kokoro (#1908) (#1225) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
…p/templates/java_library/.kokoro (#1908) (#1256) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
…v3.50.1 (#1908) Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
🤖 I have created a release *beep* *boop* --- ## [2.31.0](https://togithub.com/googleapis/java-datastore/compare/v2.30.0...v2.31.0) (2025-07-14) ### Features * Next release from main branch is 2.31.0 ([#1912](https://togithub.com/googleapis/java-datastore/issues/1912)) ([a74c46b](https://togithub.com/googleapis/java-datastore/commit/a74c46bfbac8eaf5c97fe653b740e26e7c79f4da)) ### Dependencies * Update dependency com.google.cloud:gapic-libraries-bom to v1.61.0 ([#1901](https://togithub.com/googleapis/java-datastore/issues/1901)) ([beeb125](https://togithub.com/googleapis/java-datastore/commit/beeb125efc842776facfa67742bdf8b6c167e9f2)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.50.1 ([#1908](https://togithub.com/googleapis/java-datastore/issues/1908)) ([b10e0f0](https://togithub.com/googleapis/java-datastore/commit/b10e0f0748decf06574fc0eb7ddba33ee5ece1a7)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
…p/templates/java_library/.kokoro (#1908) (#2354) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
…p/templates/java_library/.kokoro (googleapis#1908) (googleapis#1491) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
…v3.50.1 (#1908) Co-authored-by: Cindy Peng <148148319+cindy-peng@users.noreply.github.com>
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
🤖 I have created a release *beep* *boop* --- ## [2.31.0](https://togithub.com/googleapis/java-datastore/compare/v2.30.0...v2.31.0) (2025-07-14) ### Features * Next release from main branch is 2.31.0 ([#1912](https://togithub.com/googleapis/java-datastore/issues/1912)) ([af29fa0](https://togithub.com/googleapis/java-datastore/commit/af29fa0641612ca060f72d3f70534a88d19e1358)) ### Dependencies * Update dependency com.google.cloud:gapic-libraries-bom to v1.61.0 ([#1901](https://togithub.com/googleapis/java-datastore/issues/1901)) ([f66bd14](https://togithub.com/googleapis/java-datastore/commit/f66bd146e510747b5a62f02e05e73b1f12260b95)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.50.1 ([#1908](https://togithub.com/googleapis/java-datastore/issues/1908)) ([fa51122](https://togithub.com/googleapis/java-datastore/commit/fa511229d65e9c50e79dfa841aaa348f8a05986f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
…p/templates/java_library/.kokoro (googleapis#1908) (googleapis#1439) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
…v3.43.0 (googleapis#1908) * deps: update dependency com.google.cloud:sdk-platform-java-config to v3.43.0 * initialize Dialect$2 as part of strict-image-heap enforcement * Revert "initialize Dialect$2 as part of strict-image-heap enforcement" This reverts commit 7cb4d3a2c5fca89737744c7b48b05d74eed8edc8. * Reapply "initialize Dialect$2 as part of strict-image-heap enforcement" This reverts commit 292f05921acfebb8a834dcb1c457be5c0915f9c4. * initialize Dialect$1 at build time * initialize immutable map entry at build time * initialize subclass of immutable map entry * initialize database dialect $1 * add test class initialization * add test class initialization ii * move parameterized initialization to production config * move junit config to test config * Revert "move junit config to test config" This reverts commit d78fe2f5ff06c0675054deaf95fb9b709fae796f. * include runwith in initialized junit classes * add junit method order to image heap * add junit's category to image heap * remove java.lang.annotation from image heap * initialize parameterized junit class at build time * initialize framework in image-heap * initialize it test parameter at build time explicitly * explicitly initialize singleton immutablebimap --------- Co-authored-by: diegomarquezp <diegomarquezp@google.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
…p/templates/java_library/.kokoro (#1908) (#2752) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
suztomo
pushed a commit
that referenced
this pull request
Mar 30, 2026
…p/templates/java_library/.kokoro (#1908) (#1309) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sydney Munro <97561403+sydney-munro@users.noreply.github.com>
lqiu96
added a commit
that referenced
this pull request
Apr 1, 2026
) * chore: Add ObsoleteApi annotation * chore: Add tests for serializing ImpersonatedCredentials * chore: Restore old code * chore: Update error message * chore: Fix failing test issue * chore: Remove old tests referecing obsolete api functionality Original-PR: googleapis/google-auth-library-java#1908
lqiu96
added a commit
that referenced
this pull request
Apr 1, 2026
) * chore: Add ObsoleteApi annotation * chore: Add tests for serializing ImpersonatedCredentials * chore: Restore old code * chore: Update error message * chore: Fix failing test issue * chore: Remove old tests referecing obsolete api functionality Original-PR: googleapis/google-auth-library-java#1908
lqiu96
pushed a commit
that referenced
this pull request
Apr 1, 2026
…p/templates/java_library/.kokoro (#1908) (#1309) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sydney Munro <97561403+sydney-munro@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
…p/templates/java_library/.kokoro (#1908) (#1843) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Diego Marquez <diegomarquezp@google.com>
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
…o v1.126.4 (#1908) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.126.4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
…p/templates/java_library/.kokoro (#1908) (#1843) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Diego Marquez <diegomarquezp@google.com>
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
…o v1.126.4 (#1908) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.126.4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
…oogleapis#1908) Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
🤖 I have created a release *beep* *boop* --- ## [2.27.1](https://togithub.com/googleapis/java-bigtable/compare/v2.27.0...v2.27.1) (2023-09-12) ### Bug Fixes * Aggregate batching throttling latency per attempt and reset it between ([googleapis#1905](https://togithub.com/googleapis/java-bigtable/issues/1905)) ([a4d5dbd](https://togithub.com/googleapis/java-bigtable/commit/a4d5dbd446f7cbdb3fb22a542f28f3bfe154b965)) * Make sure to propagate the response when throttling is enabled ([googleapis#1908](https://togithub.com/googleapis/java-bigtable/issues/1908)) ([eaf93f3](https://togithub.com/googleapis/java-bigtable/commit/eaf93f363785ca3ac9ae90ce3446b8b377f30caa)) ### Dependencies * Update the Java code generator (gapic-generator-java) to 2.25.0 ([googleapis#1902](https://togithub.com/googleapis/java-bigtable/issues/1902)) ([af1f40c](https://togithub.com/googleapis/java-bigtable/commit/af1f40cfa116dd494073c2df4d8bdc948868aa18)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
…p/templates/java_library/.kokoro (googleapis#1908) (googleapis#2023) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1837