Fixing dependency problems for consumers of google-cloud-java - #2284
Merged
garrettjonesgoogle merged 1 commit intoJul 27, 2017
Merged
Fixing dependency problems for consumers of google-cloud-java#2284garrettjonesgoogle merged 1 commit into
garrettjonesgoogle merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jabubake
approved these changes
Jul 27, 2017
jabubake
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
google-cloud-dep-verification/google-cloud-consumer/pom.xml
| <name>Google Cloud Consumer</name> | ||
| <url>https://github.com/GoogleCloudPlatform/google-cloud-java/tree/master/google-cloud-consumer</url> | ||
| <description> | ||
| Package that consumes google-cloud to make sure consumers don't see dependency resolution problems. |
This comment was marked as spam.
neozwu
approved these changes
Jul 27, 2017
Copy link
Copy Markdown
Contributor
Author
|
Merging - the mac failure was a frequently-seen timeout. |
Sorry, something went wrong.
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
…leapis#2284) The test was broken in googleapis#2170 which added a new column family. The test was relient on the abolute column family count of the schema. This PR fixes the test by making it focus on the family its trying to delete instead of the entire schema Change-Id: I0df90e68c0b25c4e66ed7d8ae1c19ae53577443b Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various things:
Fixes #2192 .