FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

use grpc-netty-shaded by pongad · Pull Request #2832 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

use grpc-netty-shaded - #2832

Merged
pongad merged 7 commits into
googleapis:masterfrom
pongad:bump-grpc
Feb 7, 2018
ConversationCommits (7)ChecksFiles changed
Merged

use grpc-netty-shaded#2832
pongad merged 7 commits into
googleapis:masterfrom
pongad:bump-grpc

Conversation

pongad commented Feb 1, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Updates #2813 but does not close, since Spanner still requires unshaded netty.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2018
pongad commented Feb 1, 2018
View reviewed changes
Comment thread google-cloud-bom/pom.xml Outdated
<gax-httpjson.version>0.34.0</gax-httpjson.version>
<gax.version>1.17.1-SNAPSHOT</gax.version>
<gax-grpc.version>1.17.1-SNAPSHOT</gax-grpc.version>
<gax-httpjson.version>0.34.1-SNAPSHOT</gax-httpjson.version>

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java Outdated
.maxHeaderListSize(MAX_HEADER_LIST_SIZE)
.maxMessageSize(MAX_MESSAGE_SIZE);
// .maxHeaderListSize(MAX_HEADER_LIST_SIZE)
.maxInboundMessageSize(MAX_MESSAGE_SIZE);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-util/google-cloud-compat-checker/pom.xml Outdated
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative-boringssl-static</artifactId>
<version>2.0.7.Final</version>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

pongad mentioned this pull request Feb 2, 2018
Closed

pongad commented Feb 2, 2018

Copy link
Copy Markdown
Contributor Author

@garrettjonesgoogle PTAL
@vkedia Spanner is no longer affected.

garrettjonesgoogle reviewed Feb 2, 2018
View reviewed changes

garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM (and of course, don't merge until the gax dependency is not a snapshot version)

pongad mentioned this pull request Feb 5, 2018
Closed
pongad changed the title DO NOT SUBMIT: use grpc-netty-shaded use grpc-netty-shaded Feb 6, 2018

pongad commented Feb 6, 2018

Copy link
Copy Markdown
Contributor Author

@garrettjonesgoogle PTAL

garrettjonesgoogle approved these changes Feb 6, 2018
View reviewed changes

garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

re-LGTM

pongad commented Feb 7, 2018

Copy link
Copy Markdown
Contributor Author

@garrettjonesgoogle PTAL. Changed Spanner like we talked about

garrettjonesgoogle approved these changes Feb 7, 2018
View reviewed changes

garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

re-re-LGTM

pongad merged commit e4fdfad into googleapis:master Feb 7, 2018
pongad deleted the bump-grpc branch February 7, 2018 00:52

amerpersonal commented May 17, 2018

Copy link
Copy Markdown

Any progress on this? Shading somehow won't work for me. I'm using ScalaPB in SBT project. This issue is really frustrating

pongad commented May 21, 2018

Copy link
Copy Markdown
Contributor Author

@amerpersonal The PR has already merged. Could you open a separate issue with the problem you have?

chingor13 pushed a commit that referenced this pull request Feb 20, 2026
chore: Update generation configuration at Sat Jan 18 02:19:00 UTC 2025 (
a855aed 
#2832)
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
chore(main): release 2.46.0 (#2832)
9d7371d 
* chore(main): release 2.46.0

* chore: generate libraries at Fri Dec 13 00:04:04 UTC 2024

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
chore(main): release 2.75.0 (googleapis#2832)
6c634ef 
🤖 I have created a release *beep* *boop*
---


## [2.75.0](https://togithub.com/googleapis/java-bigtable/compare/v2.74.0...v2.75.0) (2026-03-24)


### Features

* Expose generated GAPIC instance admin client ([googleapis#2828](https://togithub.com/googleapis/java-bigtable/issues/2828)) ([48ad5f6](https://togithub.com/googleapis/java-bigtable/commit/48ad5f63d112da5efd6323447c4e2a970222a717))


### Bug Fixes

* **bigtable:** Add gauge handling ([googleapis#2830](https://togithub.com/googleapis/java-bigtable/issues/2830)) ([63129e2](https://togithub.com/googleapis/java-bigtable/commit/63129e28f5b0d77c92c2f7c84123883aa72aef83))
* **bigtable:** Plumb transport type correctly ([googleapis#2824](https://togithub.com/googleapis/java-bigtable/issues/2824)) ([cd7d0d9](https://togithub.com/googleapis/java-bigtable/commit/cd7d0d9f56ea7951bdb7de9d64a499ffc195b96f))
* Fix automated backup ([googleapis#2844](https://togithub.com/googleapis/java-bigtable/issues/2844)) ([a2b4a81](https://togithub.com/googleapis/java-bigtable/commit/a2b4a811568af8b6fa16a1db112cb98968d1ea29))
* Fix race in emulator controller ([googleapis#2836](https://togithub.com/googleapis/java-bigtable/issues/2836)) ([7df3a9a](https://togithub.com/googleapis/java-bigtable/commit/7df3a9ab66130150f8a930425166c97998d9a502))
* Use all known headers to detect connectivity errors ([googleapis#2841](https://togithub.com/googleapis/java-bigtable/issues/2841)) ([1a0c9aa](https://togithub.com/googleapis/java-bigtable/commit/1a0c9aaa16e0bbaf7bf01f27d0a9b39ad8f12e16))


### Dependencies

* Update shared dependencies ([googleapis#2850](https://togithub.com/googleapis/java-bigtable/issues/2850)) ([7f7fa92](https://togithub.com/googleapis/java-bigtable/commit/7f7fa92092970e57b1f67658059695c75c82a574))


### Documentation

* **bigtable:** Expose Admin API Stubs in Javadoc ([googleapis#2835](https://togithub.com/googleapis/java-bigtable/issues/2835)) ([4e3b4c6](https://togithub.com/googleapis/java-bigtable/commit/4e3b4c6fe2f67db06cd628f8516de13c1626c7db))
* **bigtable:** Expose Base Admin Clients in Javadoc ([googleapis#2833](https://togithub.com/googleapis/java-bigtable/issues/2833)) ([36a24ab](https://togithub.com/googleapis/java-bigtable/commit/36a24abcb480a05be9b7f94a55eb397a8adcb856))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

andreamlin Awaiting requested review from andreamlin
vkedia Awaiting requested review from vkedia
2 more reviewers
ejona86 ejona86 left review comments
garrettjonesgoogle garrettjonesgoogle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL