| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
- Add rewrite method to StorageRpc and DefaultStorageRpc - Add rewriter method to Storage and StorageImpl - Add unit and integration tests
- Split StorageRpc.rewrite into openRewrite and continueRewrite - Add StorageRpc.RewriteResponse and RewriteRequest classe - Move first rewrite request from BlobRewriter to StorageImpl - Change maxBytesRewrittenPerCall to megabytesRewrittenPerCall - Change BlobWriter.blobSize for BigInteger to Long - BlobRewriter extends Restorable - Refactor tests and add StorageImpl unit tests
- rename BlobRewriter to CopyWriter - update Storage.copy and Blob.copyTo methods to use StorageRpc.openRewrite - update Blob and Storage unit and intergration tests - update StorageExample
|
@aozarov I addressed all comments:
I also noticed that rewrite (in contrast with copy) fails if no content type is specified for the destination object. storage.copy(CopyRequest.of("bucket", "n1", BlobInfo.builder("bucket", "n2").build()));fails with:
Maybe @Capstan can confirm this? |
Sorry, something went wrong.
|
@mziccard I tried to reproduce the content-type requirement using the API Explorer but for me it worked fine without supplying it. |
Sorry, something went wrong.
|
@aozarov My bad, I was providing a storage object in the request body even though it had no contentType, forgot to add the check. I'm fixing this. |
Sorry, something went wrong.
|
Last comments addressed, thanks @aozarov for the thorough review! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This follows from #291. Main changes are: