Bigtable: 19 - Implement integration tests - #2997
Merged
garrettjonesgoogle merged 15 commits intoMar 20, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
igorbernstein2
force-pushed
the
19-impl-integration-tests
branch
from
4f55a01 to
efd2b05
Compare
March 8, 2018 03:59
igorbernstein2
commented
Mar 15, 2018
Comment thread
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/env/Emulator.java
|
|
||
| private ManagedChannel createChannel(int port) { | ||
| return ManagedChannelBuilder.forAddress("localhost", port) | ||
| .usePlaintext(true) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
The code LGTM. We should create a CircleCI task for this though. @igorbernstein2 Do you know what to do? @garrettjonesgoogle I think making CI run against prod for integration is OK? |
Sorry, something went wrong.
Comment thread
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/env/Emulator.java
| void start() throws Exception { | ||
| int availablePort = getAvailablePort(); | ||
|
|
||
| process = Runtime.getRuntime().exec(executable + " -port " + "" + availablePort); |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
I updated this PR to include CircleCi configs. PTAL, if it looks ok, please merge |
Sorry, something went wrong.
Comment thread
TESTING.md
Outdated
|
|
||
| To use the `prod` environment: | ||
| 1. Create a table with a column family named `cf`. | ||
| 1. Setup the target table using `google-cloud-bigtable/scripts/setup-test-table.sh` |
This comment was marked as spam.
Comment thread
google-cloud-bigtable/scripts/setup-test-table.sh
Outdated
| @@ -0,0 +1,21 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| # Setup a table to use for integration tests. | |||
This comment was marked as spam.
Comment thread
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/env/Emulator.java
Outdated
| public void run() { | ||
| try { | ||
| String line; | ||
| while ((line = reader.readLine()) != null) LOGGER.log(level, line); |
This comment was marked as spam.
Comment thread
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/env/TestEnvRule.java
Outdated
| throw new RuntimeException( | ||
| "Unknown env: " | ||
| + env | ||
| + ". Please set the system propert " |
This comment was marked as spam.
Comment thread
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/env/TestEnvRule.java
Outdated
| testEnv = ProdEnv.fromSystemProperties(); | ||
| break; | ||
| default: | ||
| throw new RuntimeException( |
This comment was marked as spam.
igorbernstein2
force-pushed
the
19-impl-integration-tests
branch
from
2be85a7 to
fc30c49
Compare
March 20, 2018 18:53
Copy link
Copy Markdown
Contributor
Author
|
Rebased & addressed all feedback. If it looks ok, please merge |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks! |
Sorry, something went wrong.
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
… to v2.29.1 (#2997) * chore(deps): update dependency com.google.cloud:google-cloud-bigtable to v2.29.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
* chore(main): release 2.51.0 * chore: generate libraries at Wed Apr 23 17:39:10 UTC 2025 * chore: cleanup changelog.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com> Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is ready for review.
MVP of integration tests for Bigtable. All data rpcs are covered. The tests can be run against an emulator or a production instance of bigtable. For the time being, the emulator controller is implemented as a process wrapper around the cbtemulator binary that is managed by gcloud. The gcloud emulator command is bypassed because it executes the emulator as a child process, preventing java from killing it. The eventual goal is to publish the binaries wrapped in a jar and bypass gcloud altogether. The Emulator wrapper class is intentionally kept private in the tests directory to postpone committing to a public api.
I setup the CircleCi configs and created the target table in the test project. Also, I updated the ITs to run in parallel and updated the verify_single_it.sh scripts to take additional args