bigquery: implement regionalization - #3131
Merged
pongad merged 2 commits intoApr 10, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pongad
commented
Apr 5, 2018
Comment thread
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/BigQueryRpc.java
| import com.google.cloud.bigquery.BigQueryException; | ||
| import java.util.Map; | ||
|
|
||
| @InternalExtensionOnly |
This comment was marked as spam.
This comment was marked as spam.
tswast
reviewed
Apr 9, 2018
Comment thread
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/BigQueryRpc.java
| import com.google.cloud.bigquery.BigQueryException; | ||
| import java.util.Map; | ||
|
|
||
| @InternalExtensionOnly |
This comment was marked as spam.
Comment thread
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
| assertThat(bigquery.getJob(job.getJobId())).isNotNull(); | ||
|
|
||
| // Wrong location shouldn't work. | ||
| assertThat(bigquery.getJob(job.getJobId().toBuilder().setLocation(wrongLocation).build())) |
This comment was marked as spam.
Comment thread
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
| table.getTableId().getDataset(), | ||
| table.getTableId().getTable()); | ||
| Job job = | ||
| bigquery.create( |
This comment was marked as spam.
tswast
approved these changes
Apr 10, 2018
| TableDataWriteChannel writer(WriteChannelConfiguration writeChannelConfiguration); | ||
|
|
||
| // TODO(pongad): document | ||
| TableDataWriteChannel writer(JobId jobId, WriteChannelConfiguration writeChannelConfiguration); |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
We should follow this PR with another change that adds location to BigQueryOptions or something (a peer to where the default project is set). |
Sorry, something went wrong.
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
…3131) * feat: Add picosecond timestamp support for Json to Proto converter * chore: Add edge cases for user input * chore: Fix lint issues * chore: Disable check for v1beta2 * chore: generate libraries at Wed Dec 10 15:59:07 UTC 2025 * chore: Address PR feedback * chore: generate libraries at Wed Dec 10 19:01:14 UTC 2025 * chore: Fix timestamp precision check condition --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
…connection to v2.37.0 (#3131)
lqiu96
added a commit
that referenced
this pull request
Mar 20, 2026
…3131) * feat: Add picosecond timestamp support for Json to Proto converter * chore: Add edge cases for user input * chore: Fix lint issues * chore: Disable check for v1beta2 * chore: generate libraries at Wed Dec 10 15:59:07 UTC 2025 * chore: Address PR feedback * chore: generate libraries at Wed Dec 10 19:01:14 UTC 2025 * chore: Fix timestamp precision check condition --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
Context in [this doc](https://docs.google.com/document/d/1wrpyBtphdenM3BNelcnpBKGADYrGJUo686HXvSA0h-0/edit?pli=1&tab=t.luhbzlh25mfs#bookmark=id.ruacqw13dxd2) This PR makes the generation workflow to always get triggered when the target repository is not a monorepo (i.e. handwritten libraries). This will still respect other changes between baseline and current configurations when it comes to PR description generation, but if no config changes are detected then no PR description will be created, assuming that the PR description of the original PR that will trigger the generation will be informative enough.
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
… name (#3131) This will have the generation present making the delete idempotent and retryable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.