FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added closing of the scheduled thread executor if appropriate by j256 · Pull Request #3234 · googleapis/google-cloud-java · GitHub

Added closing of the scheduled thread executor if appropriate - #3234

Closed
j256 wants to merge 1 commit into
googleapis:masterfrom
j256:gw-properly-close-executor
Closed

Added closing of the scheduled thread executor if appropriate#3234
j256 wants to merge 1 commit into
googleapis:masterfrom
j256:gw-properly-close-executor

Conversation

j256 commented May 4, 2018

Copy link
Copy Markdown

If we are using an InstantiatingExecutorProvider then we should shutdown() the executor so we don't leak threads.

j256 requested a review from pongad as a code owner May 4, 2018 17:51
googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2018

pongad commented May 4, 2018

Copy link
Copy Markdown
Contributor

I think ExecutorAsBackgroundResource should already take care of this right?

j256 commented May 4, 2018
edited
Loading

Copy link
Copy Markdown
Author

Ignore me. Sigh. Sorry to bother. Trying to track down GRPC and Netty thread leaks but it's not here.

j256 closed this May 4, 2018
j256 deleted the gw-properly-close-executor branch May 4, 2018 18:09
suztomo pushed a commit that referenced this pull request Mar 9, 2026
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [black](https://redirect.github.com/psf/black)
([changelog](https://redirect.github.com/psf/black/blob/main/CHANGES.md))
| `==24.4.2` -> `==24.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/black/24.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/black/24.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/black/24.4.2/24.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/black/24.4.2/24.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>psf/black (black)</summary>

###
[`v24.8.0`](https://redirect.github.com/psf/black/blob/HEAD/CHANGES.md#2480)

[Compare
Source](https://redirect.github.com/psf/black/compare/24.4.2...24.8.0)

##### Stable style

- Fix crash when `# fmt: off` is used before a closing parenthesis or
bracket.
([#&#8203;4363](https://redirect.github.com/psf/black/issues/4363))

##### Packaging

- Packaging metadata updated: docs are explictly linked, the issue
tracker is now also
linked. This improves the PyPI listing for Black.
([#&#8203;4345](https://redirect.github.com/psf/black/issues/4345))

##### Parser

- Fix regression where Black failed to parse a multiline f-string
containing another
multiline string
([#&#8203;4339](https://redirect.github.com/psf/black/issues/4339))
- Fix regression where Black failed to parse an escaped single quote
inside an f-string
    ([#&#8203;4401](https://redirect.github.com/psf/black/issues/4401))
- Fix bug with Black incorrectly parsing empty lines with a backslash
([#&#8203;4343](https://redirect.github.com/psf/black/issues/4343))
- Fix bugs with Black's tokenizer not handling `\{` inside f-strings
very well
([#&#8203;4422](https://redirect.github.com/psf/black/issues/4422))
- Fix incorrect line numbers in the tokenizer for certain tokens within
f-strings
    ([#&#8203;4423](https://redirect.github.com/psf/black/issues/4423))

##### Performance

- Improve performance when a large directory is listed in `.gitignore`
([#&#8203;4415](https://redirect.github.com/psf/black/issues/4415))

##### *Blackd*

- Fix blackd (and all extras installs) for docker container
([#&#8203;4357](https://redirect.github.com/psf/black/issues/4357))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>2.46.1</summary>

##
[2.46.1](googleapis/sdk-platform-java@v2.46.0...v2.46.1)
(2024-09-25)


### Dependencies

* update dependency black to v24.8.0
([#3234](googleapis/sdk-platform-java#3234))
([e773ec3](googleapis/sdk-platform-java@e773ec3))
* update dependency lxml to v5.3.0
([#3237](googleapis/sdk-platform-java#3237))
([ac6e622](googleapis/sdk-platform-java@ac6e622))
* update dependency net.bytebuddy:byte-buddy to v1.15.2
([#3235](googleapis/sdk-platform-java#3235))
([1e72ff0](googleapis/sdk-platform-java@1e72ff0))
* update dependency pyyaml to v6.0.2
([#3231](googleapis/sdk-platform-java#3231))
([200f332](googleapis/sdk-platform-java@200f332))
* update dependency watchdog to v4.0.2
([#3232](googleapis/sdk-platform-java#3232))
([60b7721](googleapis/sdk-platform-java@60b7721))
* update google api dependencies
([#3224](googleapis/sdk-platform-java#3224))
([0de08b2](googleapis/sdk-platform-java@0de08b2))
* update google.cloud.opentelemetry.version to v0.32.0
([#3225](googleapis/sdk-platform-java#3225))
([861f188](googleapis/sdk-platform-java@861f188))
* update grpc dependencies to v1.68.0
([#3220](googleapis/sdk-platform-java#3220))
([618288c](googleapis/sdk-platform-java@618288c))
* update junit5 monorepo to v5.11.1
([#3236](googleapis/sdk-platform-java#3236))
([1550ceb](googleapis/sdk-platform-java@1550ceb))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
…using Java (#3234)

* Create a set of code snippets for using Graph on Cloud Spanner using Java

* Update SpannerGraphSample to align with doc examples already created for gcloud and cli

* Fix syntax for upate with graph query in dml

* Remove all references to Gender

* Apply the google-java formatter to fix style

* Add integration tests for SpannerGraphSample

* Fix some comments in SpannerGraphSample.java

* Fix naming style issues

* Fix one region tag that was inconsistently named

* Fix style issue in test code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL