Prefer provided credentials if they are present in FirestoreOptions - #3460
Closed
andrewparmet wants to merge 1 commit into
Closed
Prefer provided credentials if they are present in FirestoreOptions#3460andrewparmet wants to merge 1 commit into
andrewparmet wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@schmidt-sebastian Can you take a look? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for sending this over! The problem you described exists in both the CredentialsProvider and the ChannelProvider. I have opened a PR to deal with both: #3472 Let's leave this open until 3472 is approved. |
Sorry, something went wrong.
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.51.1-SNAPSHOT</summary> ### Updating meta-information for bleeding-edge SNAPSHOT release. </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3458.
As of 0.52.0-beta, calls to setCredentials() on FirestoreOptions are effectively ignored. This is because GrpcTransportOptions.setUpCredentialsProvider() is no longer called in GrpcFirestoreRpc - instead the settings builder just pulls the credentials provider regardless of whether or not a fixed credential was supplied in the original options.
It used to be:
Today it reads:
This was changed in #3320. (Diff line)
The call can be restored in the same class with some conditional logic, or the FirestoreOptions can try to return the correct CredentialsProvider.