[DO NOT MERGE] Removing doclint disabling for bigtable on Java 8 - #3462
Closed
garrettjonesgoogle wants to merge 3 commits into
Closed
[DO NOT MERGE] Removing doclint disabling for bigtable on Java 8#3462garrettjonesgoogle wants to merge 3 commits into
garrettjonesgoogle wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Has this been tested locally against a commit snapshot that we know has a failing javadoc target? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Here's the tricky thing: this will have no effect locally. The only effect it can have is on circle, where it should expose failures. I guess the only way to test is to push a commit in the PR which has a failure and make sure that it fails on Circle (where previously it passed). I'll wait for the present test run to finish before trying that out. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hmm, was javadoc_test supposed to fail? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yes, it was supposed to fail and it didn't. Looks like this change didn't work. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
👋 @garrettjonesgoogle what's the status on this one? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Abandoning |
Sorry, something went wrong.
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.51.1</summary> ## [2.51.1](googleapis/sdk-platform-java@v2.51.0...v2.51.1) (2025-01-08) ### Dependencies * update dependency com.google.guava:guava to v33.4.0-jre ([#3473](googleapis/sdk-platform-java#3473)) ([d10e787](googleapis/sdk-platform-java@d10e787)) * update dependency com.google.guava:guava-bom to v33.4.0-jre ([#3545](googleapis/sdk-platform-java#3545)) ([94d64df](googleapis/sdk-platform-java@94d64df)) * update dependency com.google.oauth-client:google-oauth-client-bom to v1.37.0 ([#3471](googleapis/sdk-platform-java#3471)) ([47a83c0](googleapis/sdk-platform-java@47a83c0)) * update dependency net.bytebuddy:byte-buddy to v1.15.11 ([#3468](googleapis/sdk-platform-java#3468)) ([5a8c771](googleapis/sdk-platform-java@5a8c771)) * update google api dependencies ([#3461](googleapis/sdk-platform-java#3461)) ([b66bde6](googleapis/sdk-platform-java@b66bde6)) * update googleapis/java-cloud-bom digest to 03f6dcd ([#3465](googleapis/sdk-platform-java#3465)) ([54485c3](googleapis/sdk-platform-java@54485c3)) * update junit5 monorepo to v5.11.4 ([#3470](googleapis/sdk-platform-java#3470)) ([b5cf60f](googleapis/sdk-platform-java@b5cf60f)) * update netty dependencies to v4.1.116.final ([#3543](googleapis/sdk-platform-java#3543)) ([cf88994](googleapis/sdk-platform-java@cf88994)) * update repo-automation-bots digest to 8b7d94b ([#3458](googleapis/sdk-platform-java#3458)) ([a9acc11](googleapis/sdk-platform-java@a9acc11)) ### Documentation * update development guide ([#3480](googleapis/sdk-platform-java#3480)) ([cd599a2](googleapis/sdk-platform-java@cd599a2)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Hopefully) Fixes #3461