[Storage] Add a simple download sample - #3673
Closed
frankyn wants to merge 22 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
* Add presubmit test configs Add windows test config and add credentials for integration tests Invert the env var check Use fastconfigpush for faster keystore propagation Fix missing ;; in build script Allow LoggingAppender default options test to pass locally and on GCE Temporarily comment out the resource test Also grab surefire reports Fix java8-win bat path credentials path debug Set GCLOUD_PROJECT environment variable Add Java 11 test config try uploading surefire results as sponge_log.xml Fix BigTable IT args Temporarily test Java 11 Upload integration test output as sponge_log.xml too Revert "Temporarily comment out the resource test" This reverts commit f01bdbd. Revert "Allow LoggingAppender default options test to pass locally and on GCE" This reverts commit 90e28af. * Temporarily comment out the LoggingAppender default resource test. The default depends on the execution environment (GCE vs. locally) and Kokoro tests run on GCE. * Clean up debug output * Add continuous build configs * Fix the java10 build images to use Java 10, not 11
Fail fast when using utilities/batch_generate_apis.py if the local protoc version doesn't match the protobuf-java version defined in the pom.xml.
spanner: Add snippets for ReadContext
pongad
reviewed
Sep 14, 2018
Comment thread
...cloud-examples/src/main/java/com/google/cloud/examples/storage/snippets/StorageSnippets.java
Outdated
| /** | ||
| * Example of downloading a file. | ||
| */ | ||
| public void downloadFile(String bucketName, String srcFilename, |
This comment was marked as spam.
…google-cloud-java into fix-download-sample
Copy link
Copy Markdown
Contributor
Author
|
Woah... closing this out. Trying again. |
Sorry, something went wrong.
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
This PR plumbs the MTLS endpoint (separately from the resolved endpoint) from the `EndpointContext` to the `InstantiatingGrpcChannelProvider`. Why not just set the MTLS endpoint in `EndpointContext` if S2A can be used? - Although we can decide whether or not to try to use S2A in `EndpointContext`, we could fail to use S2A in `InstantiatingGrpcChannelProvider` (if autoconfig doesn't return an address), in which case we fall back to using a TLS connection - DirectPath supersedes S2A in `InstantiatingGrpcChannelProvider`, and the decision to use DirectPath is made in `InstantiatingGrpcChannelProvider`, not `EndpointContext`. We may decide to use S2A in `EndpointContext`, but when we go to create the channel in `InstantiatingGrpcChannelProvider`, we may find that we should be using DirectPath, in which case we need to use the non-MTLS endpoint
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.56.0</summary> ## [2.56.0](googleapis/sdk-platform-java@v2.55.1...v2.56.0) (2025-04-18) ### Features * Selective gapic generation phase II ([#3730](googleapis/sdk-platform-java#3730)) ([d4bafa0](googleapis/sdk-platform-java@d4bafa0)) ### Bug Fixes * **hermetic-build:** use correct image name in templated graalvm jobs ([#3743](googleapis/sdk-platform-java#3743)) ([c71223d](googleapis/sdk-platform-java@c71223d)) * plumb mtls endpoint to TransportChannelProvider ([#3673](googleapis/sdk-platform-java#3673)) ([d7daf89](googleapis/sdk-platform-java@d7daf89)) ### Dependencies * add opentelemetry gcp-resources to shared deps ([#3722](googleapis/sdk-platform-java#3722)) ([4b94c7d](googleapis/sdk-platform-java@4b94c7d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reused requester pays download sample to write this simple download sample for documentation.