Parse compute resource names [DO NOT MERGE] - #4208
Closed
andreamlin wants to merge 1 commit into
Closed
andreamlin wants to merge 1 commit into
andreamlin wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
andreamlin
commented
Dec 11, 2018
Comment thread
...clients/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/it/ITComputeTest.java
| } | ||
|
|
||
| /** For a given resource's URI, trim the path until it contains only the PathTemplate string. */ | ||
| private static String trimUrl(String url) { |
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sample regeneration of google-cloud-compute using artman with googleapis/api-common-java#68 and googleapis/discovery-artifact-manager#102.
In addition to the generated changes, ITComputeTest has been manually changed to remove the trimUrl() hack that manually removed the service address from resource paths.