FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bigtable: integrate OpenCensus tracing into the bigtable data client by igorbernstein2 · Pull Request #4493 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

Bigtable: integrate OpenCensus tracing into the bigtable data client - #4493

Merged
igorbernstein2 merged 12 commits into
googleapis:masterfrom
igorbernstein2:data-tracing
Feb 26, 2019
ConversationCommits (12)ChecksFiles changed
Merged

Bigtable: integrate OpenCensus tracing into the bigtable data client#4493
igorbernstein2 merged 12 commits into
googleapis:masterfrom
igorbernstein2:data-tracing

Conversation

igorbernstein2 commented Feb 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This adds instrumentation from gax-java to enable tracing of the Bigtable client data operations.

igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Feb 14, 2019
igorbernstein2 requested review from a team, sduskis and vam-google February 14, 2019 19:14
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2019

igorbernstein2 commented Feb 14, 2019

Copy link
Copy Markdown
Contributor Author

sduskis added the status: blocked Resolving the issue is dependent on other work. label Feb 20, 2019

codecov Bot commented Feb 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4493 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4493      +/-   ##
============================================
+ Coverage     49.15%   49.19%   +0.04%     
- Complexity    21940    21970      +30     
============================================
  Files          2077     2077              
  Lines        207215   207440     +225     
  Branches      24108    24107       -1     
============================================
+ Hits         101861   102058     +197     
- Misses        97180    97206      +26     
- Partials       8174     8176       +2
Impacted Files Coverage Δ Complexity Δ
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 98.61% <100%> (+0.04%) 17 <0> (ø) ⬇️
...v2/stub/mutaterows/MutateRowsRetryingCallable.java 92.85% <100%> (ø) 2 <0> (ø) ⬇️
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 98.47% <100%> (+0.12%) 22 <5> (+2) ⬆️
...ud/bigtable/gaxx/tracing/WrappedTracerFactory.java 100% <100%> (ø) 2 <2> (?)
.../v2/stub/mutaterows/MutateRowsAttemptCallable.java 89.1% <100%> (+0.33%) 19 <0> (ø) ⬇️
.../com/google/cloud/redis/v1/CloudRedisSettings.java 12.72% <0%> (-3.56%) 2% <0%> (ø)
...com/google/cloud/redis/v1/stub/CloudRedisStub.java 5.88% <0%> (-3.21%) 1% <0%> (ø)
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 83.46% <0%> (-0.81%) 49% <0%> (ø)
...ud/bigtable/admin/v2/BigtableTableAdminClient.java 78.63% <0%> (-0.36%) 27% <0%> (-1%)
...bigtable/admin/v2/BigtableInstanceAdminClient.java 97.09% <0%> (-0.03%) 45% <0%> (-1%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee8aa1...8c1a89c. Read the comment docs.

igorbernstein2 changed the title WIP: Bigtable: integrate OpenCensus tracing into the bigtable data client Bigtable: integrate OpenCensus tracing into the bigtable data client Feb 22, 2019
igorbernstein2 removed the status: blocked Resolving the issue is dependent on other work. label Feb 22, 2019
yoshi-automation added the 🚨 critical P0 critical issue. Requires immediate fix label Feb 22, 2019
igorbernstein2 commented Feb 22, 2019
View reviewed changes
Comment thread google-cloud-clients/google-cloud-bigtable/README.md
dependencies and configure an exporter. For example to enable tracing using
[Google Stackdriver](https://cloud.google.com/trace/docs/):

[//]: # (TODO: figure out how to keep opencensus version in sync with pom.xml)

igorbernstein2 Feb 22, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure how to ensure that the opencensus versions in this readme stay up to date with google-cloud-clients/pom.xml properties. I thought about using version markers, but those seem to only be used for internal artifacts. It would be awesome if version.txt could be generalized to manage static external versions as well.

igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 22, 2019
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 22, 2019

sduskis commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

Kokoro - Test: Code Format failed.

igorbernstein2 commented Feb 25, 2019

Copy link
Copy Markdown
Contributor Author

Format fixed

igorbernstein2 merged commit 41a04ee into googleapis:master Feb 26, 2019
kolea2 mentioned this pull request Mar 4, 2019
Merged
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
Bigtable: integrate OpenCensus tracing into the bigtable data client (g…
3411063 
…oogleapis#4493)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vam-google Awaiting requested review from vam-google
1 more reviewer
sduskis sduskis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. 🚨 critical P0 critical issue. Requires immediate fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL