FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump gax-java dependency by andreamlin · Pull Request #4496 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

Bump gax-java dependency - #4496

Merged
sduskis merged 4 commits into
googleapis:masterfrom
andreamlin:bump_gax
Feb 15, 2019
ConversationCommits (4)ChecksFiles changed
Merged

Bump gax-java dependency#4496
sduskis merged 4 commits into
googleapis:masterfrom
andreamlin:bump_gax

Conversation

andreamlin commented Feb 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

To keep the same common-protos dependency at 1.14.0 as in #4486

andreamlin requested a review from a team February 14, 2019 20:35
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2019
andreamlin requested a review from kolea2 February 14, 2019 20:35

andreamlin commented Feb 14, 2019

Copy link
Copy Markdown
Contributor Author

PTAL

sduskis commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

Can you please upgrade the other dependencies that changed in gax? (I know that at least grpc and opencensus were upgraded)

sduskis commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

Should we update common proto here instead of #4486?

andreamlin commented Feb 14, 2019

Copy link
Copy Markdown
Contributor Author

Ok, also updated the common protos dep

sduskis commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

Sorry to do this... google-api-grpc also has grpc dependencies (and maybe others?) that also need to be update.

After this exercise we should consider moving common properties up to the root pom.

sduskis commented Feb 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

It looks like there is a convergence issue:

[ERROR] Failed to execute goal on project google-cloud-examples: Could not resolve dependencies for project com.google.cloud:google-cloud-examples:jar:0.80.1-alpha-SNAPSHOT: Failed to collect dependencies for com.google.cloud:google-cloud-examples:jar:0.80.1-alpha-SNAPSHOT: Could not resolve version conflict among [

com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT -> 
        com.google.cloud:google-cloud-core-grpc:jar:1.62.1-SNAPSHOT ->
        io.grpc:grpc-protobuf:jar:1.18.0 ->
        io.grpc:grpc-core:jar:1.18.0,
 
com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT ->
        com.google.cloud:google-cloud-core-grpc:jar:1.62.1-SNAPSHOT ->
        io.grpc:grpc-protobuf:jar:1.18.0 ->
        io.grpc:grpc-protobuf-lite:jar:1.18.0 ->
        io.grpc:grpc-core:jar:1.18.0,

com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT ->
        io.grpc:grpc-stub:jar:1.18.0 ->
        io.grpc:grpc-core:jar:1.18.0,

com.google.cloud:google-cloud-bigtable:jar:0.80.1-alpha-SNAPSHOT ->
        io.grpc:grpc-auth:jar:1.18.0 ->
        io.grpc:grpc-core:jar:[1.18.0,1.18.0],

com.google.cloud:google-cloud-datastore:jar:1.62.1-SNAPSHOT ->
        io.grpc:grpc-core:jar:1.18.0,

com.google.cloud:google-cloud-logging:jar:1.62.1-SNAPSHOT ->
        com.google.api:gax-grpc:jar:1.38.0 ->
        io.grpc:grpc-netty-shaded:jar:1.17.1 ->
        io.grpc:grpc-core:jar:[1.17.1,1.17.1],

com.google.cloud:google-cloud-logging:jar:1.62.1-SNAPSHOT ->
        com.google.api:gax-grpc:jar:1.38.0 ->
        io.grpc:grpc-alts:jar:1.17.1 ->
        io.grpc:grpc-core:jar:[1.17.1,1.17.1],

com.google.cloud:google-cloud-logging:jar:1.62.1-SNAPSHOT ->
        com.google.api:gax-grpc:jar:1.38.0 ->
        io.grpc:grpc-alts:jar:1.17.1 ->
        io.grpc:grpc-grpclb:jar:1.17.1 ->
        io.grpc:grpc-core:jar:[1.17.1,1.17.1],

com.google.cloud:google-cloud-spanner:jar:1.7.1-SNAPSHOT ->
        io.opencensus:opencensus-contrib-grpc-util:jar:0.18.0 ->
        io.grpc:grpc-core:jar:1.14.0] ->

andreamlin commented Feb 15, 2019

Copy link
Copy Markdown
Contributor Author

@sduskis is it ok now? i just forgot to bump google-cloud-logging's dep on gax

sduskis merged commit 0165145 into googleapis:master Feb 15, 2019
andreamlin deleted the bump_gax branch February 15, 2019 17:26
andreamlin mentioned this pull request Feb 15, 2019
Closed
JesseLovelace mentioned this pull request Feb 21, 2019
Merged
kolea2 mentioned this pull request Mar 19, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kolea2 Awaiting requested review from kolea2
1 more reviewer
sduskis sduskis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL