FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Datastore: Fix `more_results` value to query results by pmakani · Pull Request #4516 · googleapis/google-cloud-java · GitHub

Datastore: Fix more_results value to query results - #4516

Merged
sduskis merged 4 commits into
googleapis:masterfrom
pmakani:api-datastore-4504
Feb 21, 2019
Merged

Datastore: Fix more_results value to query results#4516
sduskis merged 4 commits into
googleapis:masterfrom
pmakani:api-datastore-4504

Conversation

pmakani commented Feb 19, 2019

Copy link
Copy Markdown

Fixes #4504

pmakani requested a review from a team February 19, 2019 18:18
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019

codecov Bot commented Feb 20, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@e67981a). Click here to learn what that means.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master    #4516   +/-   ##
=========================================
  Coverage          ?   48.84%           
  Complexity        ?    21947           
=========================================
  Files             ?     2077           
  Lines             ?   207098           
  Branches          ?    23429           
=========================================
  Hits              ?   101153           
  Misses            ?    97098           
  Partials          ?     8847
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/datastore/QueryResultsImpl.java 88.23% <66.66%> (ø) 17 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67981a...ff2f1ef. Read the comment docs.

sduskis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add a unit test for the getter.

sduskis added the api: datastore Issues related to the Datastore API. label Feb 20, 2019

pmakani commented Feb 21, 2019

Copy link
Copy Markdown
Author

Done.

sduskis merged commit a1679e4 into googleapis:master Feb 21, 2019

mtso commented Feb 21, 2019

Copy link
Copy Markdown

Thank you!

pmakani deleted the api-datastore-4504 branch February 25, 2019 12:31
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
* add moreResults

* added getter

* updated code

* modified code and added test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL