FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[cloud spanner] Add dependency for surefire-junit47 by qian-long · Pull Request #4526 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

[cloud spanner] Add dependency for surefire-junit47 - #4526

Merged
sduskis merged 3 commits into
googleapis:masterfrom
qian-long:junit-fix-upstream
Feb 21, 2019
ConversationCommits (3)ChecksFiles changed
Merged

[cloud spanner] Add dependency for surefire-junit47#4526
sduskis merged 3 commits into
googleapis:masterfrom
qian-long:junit-fix-upstream

Conversation

qian-long commented Feb 21, 2019

Copy link
Copy Markdown

Fixes junit dependency issue when running tests in a VPC.

qian-long requested a review from a team February 21, 2019 00:59
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2019

qian-long commented Feb 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Author

@silverdev, @snehashah16, @nithinsujir, @kolea2 for FYI

pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 21, 2019
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 21, 2019

codecov Bot commented Feb 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4526 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4526      +/-   ##
============================================
- Coverage     49.15%   49.15%   -0.01%     
  Complexity    21934    21934              
============================================
  Files          2077     2077              
  Lines        207174   207174              
  Branches      24099    24099              
============================================
- Hits         101841   101838       -3     
- Misses        97160    97163       +3     
  Partials       8173     8173
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/storage/testing/RemoteStorageHelper.java 55.28% <0%> (-2.44%) 8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ab941...73a4036. Read the comment docs.

sduskis commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Is this something we should apply for all projects?

qian-long commented Feb 21, 2019

Copy link
Copy Markdown
Author

I think this was only missing for spanner. For example, bigtable has a clause for this: https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-bigtable/pom.xml#L134

sduskis merged commit 227f5b8 into googleapis:master Feb 21, 2019
JesseLovelace mentioned this pull request Feb 21, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
sduskis sduskis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL