FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove package private dead code from the subscriber client library. by dpcollins-google · Pull Request #4589 · googleapis/google-cloud-java · GitHub

Remove package private dead code from the subscriber client library. - #4589

Merged
sduskis merged 1 commit into
googleapis:masterfrom
dpcollins-google:remove_subscriber_dead_code
Feb 28, 2019
Merged

Remove package private dead code from the subscriber client library.#4589
sduskis merged 1 commit into
googleapis:masterfrom
dpcollins-google:remove_subscriber_dead_code

Conversation

Copy link
Copy Markdown

None of this code is ever called, and none of it is usable outside of the library.

…None of this code is ever called, and none of it is usable outside of the library.
dpcollins-google requested a review from a team February 28, 2019 15:09
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2019
sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2019
yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 28, 2019

codecov Bot commented Feb 28, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4589 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4589      +/-   ##
============================================
- Coverage     49.18%   49.17%   -0.01%     
+ Complexity    21962    21952      -10     
============================================
  Files          2078     2078              
  Lines        207507   207457      -50     
  Branches      24121    24107      -14     
============================================
- Hits         102055   102017      -38     
+ Misses        97276    97267       -9     
+ Partials       8176     8173       -3
Impacted Files Coverage Δ Complexity Δ
...cloud/pubsub/v1/StreamingSubscriberConnection.java 63.2% <ø> (-7.69%) 9 <0> (-9)
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 83.13% <100%> (+3.89%) 17 <0> (ø) ⬇️
...gle/cloud/pubsub/v1/SubscriptionAdminSettings.java 14.28% <0%> (-1.59%) 4% <0%> (-1%)
...gle/cloud/storage/testing/RemoteStorageHelper.java 57.72% <0%> (+2.43%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 921be7b...532bcd5. Read the comment docs.

sduskis merged commit 1e18a7d into googleapis:master Feb 28, 2019
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
…None of this code is ever called, and none of it is usable outside of the library. (#4589)
meltsufin pushed a commit that referenced this pull request May 1, 2026
…None of this code is ever called, and none of it is usable outside of the library. (#4589)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL