Encapsulating a notion of "message batch" in pub/sub - #4951
Merged
sduskis merged 3 commits intoApr 16, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is inspired by the changes in the ordering keys branch.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #4951 +/- ##
=========================================
Coverage ? 50.05%
Complexity ? 23699
=========================================
Files ? 2233
Lines ? 226002
Branches ? 24228
=========================================
Hits ? 113128
Misses ? 103533
Partials ? 9341
Continue to review full report at Codecov.
|
Sorry, something went wrong.
olavloite
approved these changes
Apr 16, 2019
Comment thread
...le-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
Outdated
| private int getMessagesCount() { | ||
| return messages.size(); | ||
| } | ||
| }; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Minor nitpick: semicolon at the end of class definition is not required (and not common) in Java.
Otherwise, this looks good to me.
Sorry, something went wrong.
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
* Encapsulating a notion of "message batch" in pub/sub This is inspired by the changes in the ordering keys branch. * Update Publisher.java
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
* Encapsulating a notion of "message batch" in pub/sub This is inspired by the changes in the ordering keys branch. * Update Publisher.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is inspired by the changes in the ordering keys branch.
@kimkyung-goog, FYI