FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Firestore: Add support for IN Queries by schmidt-sebastian · Pull Request #5803 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

Firestore: Add support for IN Queries - #5803

Merged
BenWhitehead merged 9 commits into
masterfrom
mrschmidt/inqueries
Oct 30, 2019
ConversationCommits (9)ChecksFiles changed
Merged

Firestore: Add support for IN Queries#5803
BenWhitehead merged 9 commits into
masterfrom
mrschmidt/inqueries

Conversation

schmidt-sebastian commented Jul 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This adds support for Firestore's new IN and ARRAY_CONTAINS_ANY queries.

This can not yet be merged:

  • The underlying Proto change is not public yet (hence the PR won't compile)
  • The backend does not yet support these types of queries (the test won't pass)

This PR is meant to be a reference for other languages.

Port of googleapis/nodejs-firestore#715

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2019
schmidt-sebastian added the status: blocked Resolving the issue is dependent on other work. label Jul 23, 2019

schmidt-sebastian commented Jul 23, 2019

Copy link
Copy Markdown
Contributor Author

cc @thebrianchen

thebrianchen approved these changes Jul 24, 2019
View reviewed changes

thebrianchen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just double checking, do we need any serialization/deserialization tests for the java sdk?
otherwise, LGTM

schmidt-sebastian commented Jul 28, 2019

Copy link
Copy Markdown
Contributor Author

Just double checking, do we need any serialization/deserialization tests for the java sdk?
otherwise, LGTM

We create the Proto directly via the somewhat hidden whereHelper. The unit tests then confirm that we created the expected request.

BenWhitehead commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

@schmidt-sebastian Can we rebase this and get it fixed up to merge now that the protos are available as of #6479?

schmidt-sebastian commented Oct 25, 2019

Copy link
Copy Markdown
Contributor Author

We can probably launch this as soon as next week. I will rebase the PR on Monday.

codecov Bot commented Oct 28, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5803 into master will increase coverage by 0.28%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #5803      +/-   ##
============================================
+ Coverage     46.06%   46.35%   +0.28%     
- Complexity    28002    28021      +19     
============================================
  Files          2613     2613              
  Lines        287940   288087     +147     
  Branches      32912    33778     +866     
============================================
+ Hits         132641   133531     +890     
- Misses       144230   144312      +82     
+ Partials      11069    10244     -825
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/firestore/Query.java 91.89% <66.66%> (-0.7%) 101 <4> (+11)
.../cloud/datastore/testing/LocalDatastoreHelper.java 80.59% <0%> (-4.48%) 17% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...able/gaxx/reframing/ReframingResponseObserver.java 88.99% <0%> (-1.84%) 29% <0%> (-1%)
...le/cloud/storage/contrib/nio/CloudStoragePath.java 75.67% <0%> (-0.69%) 51% <0%> (ø)
...ge/contrib/nio/CloudStorageFileSystemProvider.java 62.76% <0%> (-0.3%) 73% <0%> (ø)
...ain/java/com/google/cloud/logging/LoggingImpl.java 87.9% <0%> (-0.19%) 73% <0%> (ø)
...ain/java/com/google/cloud/storage/StorageImpl.java 76.72% <0%> (-0.16%) 114% <0%> (+6%)
...m/google/cloud/spanner/jdbc/JdbcTypeConverter.java 74.86% <0%> (-0.14%) 88% <0%> (ø)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 87.67% <0%> (-0.13%) 165% <0%> (ø)
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3157b23...0a631c7. Read the comment docs.

BenWhitehead commented Oct 28, 2019

Copy link
Copy Markdown
Contributor

@schmidt-sebastian The two new integration tests are failing with assertion errors. Does the integration test project need to be given explicit access for these to pass?

schmidt-sebastian commented Oct 28, 2019

Copy link
Copy Markdown
Contributor Author

@schmidt-sebastian The two new integration tests are failing with assertion errors. Does the integration test project need to be given explicit access for these to pass?

No, they just have never been run and are buggy. I am updating them right now, and will also fix one incompatibility with Java 7 that we just noticed on Android.

schmidt-sebastian commented Oct 28, 2019

Copy link
Copy Markdown
Contributor Author

I updated the PR, it should now be in a good state. At first, we wanted to add a varargs method, but we noticed that it break when a user calls Query.whereIn(field, null) since Java 7 picks the wrong overload (@NunNull List<> is preferred). We decided to punt on this for now and may add the overloads later if requested.

BenWhitehead suggested changes Oct 29, 2019
View reviewed changes

BenWhitehead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like there is a compiler error due to in incorrect variable name

[ERROR] /tmp/src/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java:[632,85] cannot find symbol
[ERROR]   symbol:   variable value
[ERROR]   location: class com.google.cloud.firestore.Query

Comment thread google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java Outdated
schmidt-sebastian and others added 3 commits October 29, 2019 12:59
Update google-cloud-clients/google-cloud-firestore/src/main/java/com/…
06e24a2 
…google/cloud/firestore/Query.java

Co-Authored-By: BenWhitehead <BenWhitehead@users.noreply.github.com>
Fix compile
853150c
Code format
0a631c7
schmidt-sebastian removed the status: blocked Resolving the issue is dependent on other work. label Oct 29, 2019
schmidt-sebastian changed the title Firestore: Add support for IN Queries (blocked) Firestore: Add support for IN Queries Oct 29, 2019
BenWhitehead merged commit bead76a into master Oct 30, 2019
BenWhitehead deleted the mrschmidt/inqueries branch October 30, 2019 15:36
chingor13 mentioned this pull request Oct 30, 2019
Merged
codyoss mentioned this pull request Nov 6, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
BenWhitehead BenWhitehead approved these changes
thebrianchen thebrianchen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

BenWhitehead

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL