Remove JobInfo hierarchy, add JobConfiguration hierarchy - #584
Merged
aozarov merged 6 commits intoJan 29, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mziccard
force-pushed
the
bigquery-hierachies
branch
from
e0a6fec to
84402ac
Compare
January 26, 2016 15:49
Comment thread
gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/LoadConfiguration.java
Outdated
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
Done withe the review. looks good. Main comment (as discussed verbally) is the suggestion to make JobConfiguration interface an abstract class (and use package scope methods to set or get from pb). |
Sorry, something went wrong.
mziccard
force-pushed
the
bigquery-hierachies
branch
from
022ad08 to
d170550
Compare
January 27, 2016 12:23
mziccard
force-pushed
the
bigquery-hierachies
branch
from
d170550 to
a2c8b39
Compare
January 27, 2016 12:40
Comment thread
gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/BigQueryImpl.java
Outdated
This comment was marked as spam.
Comment thread
gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/ExtractJobConfiguration.java
Outdated
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
Looks great! Do you plan to do the same for BaseTableInfo ? BTW, looks like BigQueryException has 2 unused import statements. |
Sorry, something went wrong.
Comment thread
gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/LoadJobConfiguration.java
Outdated
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes JobInfo hierarchy and replaces it with a hierarchy on JobConfiguration. This change is needed to make functional Job extend JobInfo. Notes: