docs: update Pub/Sub publisher docstring example - #6100
Merged
chingor13 merged 2 commits intoAug 21, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@chingor13 Do you know why the test kept failing? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
It looks like a flakey spanner JDBC test. @kolea2, @olavloite might know more. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry about that, we're tracking #6075 to fix this. I've rerun the build. |
Sorry, something went wrong.
kolea2
reviewed
Aug 20, 2019
Comment thread
...le-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
Outdated
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #6100 +/- ##
============================================
+ Coverage 47.38% 47.4% +0.01%
- Complexity 27180 27228 +48
============================================
Files 2523 2523
Lines 274580 274830 +250
Branches 31380 31391 +11
============================================
+ Hits 130118 130289 +171
- Misses 134852 134928 +76
- Partials 9610 9613 +3
Continue to review full report at Codecov.
|
Sorry, something went wrong.
chingor13
approved these changes
Aug 21, 2019
This was referenced Aug 22, 2019
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
* update docstring for ApiFutures.addCallback() * go back to 2016
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
* update docstring for ApiFutures.addCallback() * go back to 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3920
Missed the docstring in a previous PR #4120 that addressed the same issue.