spanner-jdbc: Metadata queries should be allowed during a DDL batch - #6939
Merged
olavloite merged 3 commits intoDec 3, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
A DDL batch would refuse any query that would be executed during an active batch. This causes problems for frameworks, such as Hibernate, that might execute such queries during datamodel generation to check which database objects (tables, indices, ...) already exist in the database. This change will allow specifically internally generated metadata queries to be executed during a DDL batch. All other queries will still be refused. The metadata queries will be executed using a single use read-only transaction.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #6939 +/- ##
============================================
+ Coverage 41.04% 41.18% +0.13%
- Complexity 5289 5310 +21
============================================
Files 360 360
Lines 50413 50436 +23
Branches 6913 6918 +5
============================================
+ Hits 20692 20770 +78
+ Misses 28244 28182 -62
- Partials 1477 1484 +7
Continue to review full report at Codecov.
|
Sorry, something went wrong.
dzou
approved these changes
Nov 28, 2019
dzou
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice! Thank you, this is very helpful!
Sorry, something went wrong.
meltsufin
approved these changes
Dec 2, 2019
meltsufin
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
skuruppu
approved these changes
Dec 2, 2019
olavloite
deleted the
spanner-jdbc-allow-metadata-queries-in-ddl-batch
branch
December 3, 2019 07:46
This was referenced Dec 4, 2019
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
…oogleapis#6939) * Metadata queries should be allowed in a DDL batch A DDL batch would refuse any query that would be executed during an active batch. This causes problems for frameworks, such as Hibernate, that might execute such queries during datamodel generation to check which database objects (tables, indices, ...) already exist in the database. This change will allow specifically internally generated metadata queries to be executed during a DDL batch. All other queries will still be refused. The metadata queries will be executed using a single use read-only transaction. * ignore non-internal options * run code formatter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A DDL batch would refuse any query that would be executed during an active batch. This causes problems for frameworks, such as Hibernate, that might execute such queries during datamodel generation to check which database objects (tables, indices, ...) already exist in the database. This change will allow specifically internally generated metadata queries to be executed during a DDL batch. All other queries will still be refused. The metadata queries will be executed using a
single use read-only transaction.