FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(bazel): [java-datacatalog] Update WORKSPACE files for rules_gapic, gax_java, generator_java versions by lqiu96 · Pull Request #8467 · googleapis/google-cloud-java · GitHub

/ google-cloud-java Public

chore(bazel): [java-datacatalog] Update WORKSPACE files for rules_gapic, gax_java, generator_java versions - #8467

Closed
lqiu96 wants to merge 4 commits into
mainfrom
main-fix
ConversationCommits (4)ChecksFiles changed
Closed

chore(bazel): [java-datacatalog] Update WORKSPACE files for rules_gapic, gax_java, generator_java versions#8467
lqiu96 wants to merge 4 commits into
mainfrom
main-fix

Conversation

lqiu96 commented Sep 27, 2022

Copy link
Copy Markdown
Member

This is to resolve a diff that was discovered in #8448

lqiu96 mentioned this pull request Sep 27, 2022
Closed

suztomo commented Sep 27, 2022

Copy link
Copy Markdown
Member

googleapis/java-datacatalog#795 was merged on May. This monorepo started late August. That PR 794 cannot be the cause of diff.

lqiu96 commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

googleapis/java-datacatalog#795 was merged on May. This monorepo started late August. That PR 794 cannot be the cause of diff.

I don't think the diff was because of googleapis/java-datacatalog#795 -- It looks like the changes in java-datacatalog#795 was reverted

PR 8340 reverted the changes that went in googleapis/java-datacatalog#795: https://github.com/googleapis/google-cloud-java/pull/8340/files#diff-ebe3de62a47cce7750d33539cd0fec2f5169fe3d14c490b48bdd9c14a08a1b98

This is the diff PR #8340 created for DataCatalogSettings.java java-datacatalog:

This is what is in java-datacatalog now:

suztomo commented Sep 27, 2022

Copy link
Copy Markdown
Member

@lqiu96 The java-datacatalog repository hasn't merged googleapis/java-datacatalog#857 (open).

lqiu96 commented Sep 27, 2022

Copy link
Copy Markdown
Member Author

I see. Ok, I'll leave java-datacatalog files as a known difference then. We'll have to wait for the person on support to merge that PR.

lqiu96 closed this Sep 27, 2022

suztomo commented Sep 27, 2022

Copy link
Copy Markdown
Member

I just merged googleapis/java-datacatalog#857

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL